linux-kernel - Re: [PATCH] fs: export anon_inode_make_secure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250619-zerstochen-lamellen-b158317258e6@brauner>
Date: Thu, 19 Jun 2025 10:45:16 +0200
From: Christian Brauner <brauner@...nel.org>
To: Shivank Garg <shivankg@....com>
Cc: Christian Brauner <brauner@...nel.org>,
	seanjc@...gle.com,
	vbabka@...e.cz,
	willy@...radead.org,
	pbonzini@...hat.com,
	tabba@...gle.com,
	afranji@...gle.com,
	ackerleytng@...gle.com,
	jack@...e.cz,
	hch@...radead.org,
	cgzones@...glemail.com,
	ira.weiny@...el.com,
	roypat@...zon.co.uk,
	linux-fsdevel@...r.kernel.org,
	linux-mm@...ck.org,
	linux-kernel@...r.kernel.org,
	linux-security-module@...r.kernel.org,
	david@...hat.com,
	akpm@...ux-foundation.org,
	paul@...l-moore.com,
	rppt@...nel.org,
	viro@...iv.linux.org.uk
Subject: Re: [PATCH] fs: export anon_inode_make_secure_inode() and fix secretmem LSM bypass

On Thu, 19 Jun 2025 07:31:37 +0000, Shivank Garg wrote:
> Export anon_inode_make_secure_inode() to allow KVM guest_memfd to create
> anonymous inodes with proper security context. This replaces the current
> pattern of calling alloc_anon_inode() followed by
> inode_init_security_anon() for creating security context manually.
> 
> This change also fixes a security regression in secretmem where the
> S_PRIVATE flag was not cleared after alloc_anon_inode(), causing
> LSM/SELinux checks to be bypassed for secretmem file descriptors.
> 
> [...]

Applied to the vfs.fixes branch of the vfs/vfs.git tree.
Patches in the vfs.fixes branch should appear in linux-next soon.

Please report any outstanding bugs that were missed during review in a
new review to the original patch series allowing us to drop it.

It's encouraged to provide Acked-bys and Reviewed-bys even though the
patch has now been applied. If possible patch trailers will be updated.

Note that commit hashes shown below are subject to change due to rebase,
trailer updates or similar. If in doubt, please check the listed branch.

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/vfs/vfs.git
branch: vfs.fixes

[1/1] fs: export anon_inode_make_secure_inode() and fix secretmem LSM bypass
      https://git.kernel.org/vfs/vfs/c/c696307648ea