linux-kernel - Re: [PATCH] arm64: dts: ti: k3-am69-sk: Add idle-states for remaining SERDES instances

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <b446e04f-0c4a-4cce-8330-0b7bc1e330dc@ti.com>
Date: Thu, 19 Jun 2025 16:09:22 +0530
From: Hrushikesh Salunke <h-salunke@...com>
To: Siddharth Vadapalli <s-vadapalli@...com>
CC: <nm@...com>, <vigneshr@...com>, <kristo@...nel.org>, <robh@...nel.org>,
        <krzk+dt@...nel.org>, <conor+dt@...nel.org>,
        <linux-arm-kernel@...ts.infradead.org>, <devicetree@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>, <danishanwar@...com>, <srk@...com>,
        Hrushikesh Salunke <h-salunke@...com>
Subject: Re: [PATCH] arm64: dts: ti: k3-am69-sk: Add idle-states for remaining
 SERDES instances



On 19/06/25 11:35, Siddharth Vadapalli wrote:
> On Wed, Jun 11, 2025 at 06:23:24PM +0530, Siddharth Vadapalli wrote:
>> On Mon, Jun 09, 2025 at 05:29:21PM +0530, Hrushikesh Salunke wrote:
>>> In AM69 SoC there are 4 instances of the 4 lane SERDES. So in
>>> "serdes_ln_ctrl" node there are total 16 entries in "mux-reg-mask"
>>> property. But "idle-states" is defined only for the lanes of first two
>>> SERDES instances. For completeness, set the "idle-states" of lanes of
>>> remaining SERDES instances to a default value of "unused".
>>>
>>> Signed-off-by: Hrushikesh Salunke <h-salunke@...com>
>>
>> Reviewed-by: Siddharth Vadapalli <s-vadapalli@...com>
> 
> I failed to notice that this change will introduce a regression on
> AM69-SK for CPSW AND Display which rely on the SERDES Lane Mapping for
> SERDES2 and SERDES4 being at their reset value of "zero". This patch
> should be fixed by updating it to the following:
> 
> 	<J784S4_SERDES2_LANE0_IP2_UNUSED>, <J784S4_SERDES2_LANE1_IP2_UNUSED>,
> 	<J784S4_SERDES2_LANE2_QSGMII_LANE1>, <J784S4_SERDES2_LANE3_QSGMII_LANE2>,
> 	<J784S4_SERDES4_LANE0_EDP_LANE0>, <J784S4_SERDES4_LANE1_EDP_LANE1>,
> 	<J784S4_SERDES4_LANE2_EDP_LANE2>, <J784S4_SERDES4_LANE3_EDP_LANE3>;
> 
> 

Thanks for noticing this Siddharth. I will correct this and post the v2
for this patch.

Regards,
Hrushikesh