linux-kernel - Re: [PATCH net-next] net/smc: remove unused function smc_lo_supports

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250619104201.GI1699@horms.kernel.org>
Date: Thu, 19 Jun 2025 11:42:01 +0100
From: Simon Horman <horms@...nel.org>
To: Wang Liang <wangliang74@...wei.com>
Cc: wenjia@...ux.ibm.com, jaka@...ux.ibm.com, alibuda@...ux.alibaba.com,
	tonylu@...ux.alibaba.com, guwen@...ux.alibaba.com,
	davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org,
	pabeni@...hat.com, yuehaibing@...wei.com,
	zhangchangzhong@...wei.com, linux-rdma@...r.kernel.org,
	linux-s390@...r.kernel.org, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next] net/smc: remove unused function
 smc_lo_supports_v2

On Thu, Jun 19, 2025 at 11:08:54AM +0800, Wang Liang wrote:
> The smcd_ops->supports_v2 is only called in smcd_register_dev(), which
> calls function smcd_supports_v2 for ism. For loopback-ism, function
> smc_lo_supports_v2 is unused, remove it.
> 
> Signed-off-by: Wang Liang <wangliang74@...wei.com>

Thanks, I agree with this analysis.

Reviewed-by: Simon Horman <horms@...nel.org>