linux-kernel - Re: [PATCH v2] usbip: convert to use faux

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2025061955-pungent-overripe-f8e4@gregkh>
Date: Thu, 19 Jun 2025 13:02:17 +0200
From: Greg KH <gregkh@...uxfoundation.org>
To: Shuah Khan <skhan@...uxfoundation.org>
Cc: Zongmin Zhou <min_halo@....com>, shuah@...nel.org,
	valentina.manea.m@...il.com, i@...ithal.me,
	linux-kernel@...r.kernel.org, linux-usb@...r.kernel.org,
	zhouzongmin@...inos.cn
Subject: Re: [PATCH v2] usbip: convert to use faux_device

On Tue, Jun 10, 2025 at 09:15:51AM -0600, Shuah Khan wrote:
> On 6/4/25 00:54, Zongmin Zhou wrote:
> > From: Zongmin Zhou <zhouzongmin@...inos.cn>
> > 
> > The vhci driver does not need to create a platform device,
> > it only did so because it was simple to do that in order to
> > get a place in sysfs to hang some device-specific attributes.
> > Now the faux device interface is more appropriate,change it
> > over to use the faux bus instead.
> > 
> > Signed-off-by: Zongmin Zhou <zhouzongmin@...inos.cn>
> > ---
> > Changes in v2:
> > - don't change faux create api,just call probe on vhci_hcd_init.
> 
> I will defer the review to Greg on this.
> 
> I am fine with the change if Greg is happy with it. :)

Well the build errors aren't that good, but overall, yes, it's a nice
change :)

thanks,

greg k-h