linux-kernel - Re: [PATCH v4] mmc: rtsx: usb add 74 clocks in poweron flow

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAPDyKFpnpFyRLVyMBus=wbDVtnuz92uXo2KYv1jkDuAH83WydA@mail.gmail.com>
Date: Thu, 19 Jun 2025 13:20:04 +0200
From: Ulf Hansson <ulf.hansson@...aro.org>
To: Ricky Wu <ricky_wu@...ltek.com>
Cc: linux-kernel@...r.kernel.org, linux-mmc@...r.kernel.org, 
	viro@...iv.linux.org.uk
Subject: Re: [PATCH v4] mmc: rtsx: usb add 74 clocks in poweron flow

On Mon, 16 Jun 2025 at 08:52, Ricky Wu <ricky_wu@...ltek.com> wrote:
>
> SD spec definition:
> "Host provides at least 74 Clocks before issuing first command"
>
> add issue the clocks when power_mode is POWER_UP
> and stop the signal when power_mode is POWER_ON
>
> Signed-off-by: Ricky Wu <ricky_wu@...ltek.com>

Applied for next, thanks!

Kind regards
Uffe


> ---
> v2: remove delay 100ms in power_on
> v3: Use switch-case instead of if statements
> v4: re-base on the patches
> https://lore.kernel.org/all/20250610111633.504366-1-ulf.hansson@linaro.org/
> ---
>  drivers/mmc/host/rtsx_usb_sdmmc.c | 5 +++++
>  1 file changed, 5 insertions(+)
>
> diff --git a/drivers/mmc/host/rtsx_usb_sdmmc.c b/drivers/mmc/host/rtsx_usb_sdmmc.c
> index c1fdcc334c8f..239eb9acf7a7 100644
> --- a/drivers/mmc/host/rtsx_usb_sdmmc.c
> +++ b/drivers/mmc/host/rtsx_usb_sdmmc.c
> @@ -1014,6 +1014,7 @@ static void sd_set_power_mode(struct rtsx_usb_sdmmc *host,
>                 unsigned char power_mode)
>  {
>         int err;
> +       struct rtsx_ucr *ucr = host->ucr;
>
>         if (power_mode == host->power_mode)
>                 return;
> @@ -1031,9 +1032,13 @@ static void sd_set_power_mode(struct rtsx_usb_sdmmc *host,
>                 err = sd_power_on(host);
>                 if (err)
>                         dev_dbg(sdmmc_dev(host), "power-on (err = %d)\n", err);
> +               /* issue the clock signals to card at least 74 clocks */
> +               rtsx_usb_write_register(ucr, SD_BUS_STAT, SD_CLK_TOGGLE_EN, SD_CLK_TOGGLE_EN);
>                 break;
>
>         case MMC_POWER_ON:
> +               /* stop to send the clock signals */
> +               rtsx_usb_write_register(ucr, SD_BUS_STAT, SD_CLK_TOGGLE_EN, 0x00);
>         case MMC_POWER_UNDEFINED:
>                 break;
>
> --
> 2.25.1
>