linux-kernel - Re: [PATCH v1] mmc: Convert ternary operator to str

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAPDyKFqJuWC+XtC-WByRAeXPT=i4W4L5GzVKvs4+th4Fo4BNKA@mail.gmail.com>
Date: Thu, 19 Jun 2025 13:20:11 +0200
From: Ulf Hansson <ulf.hansson@...aro.org>
To: Li Dong <lidong@...o.com>
Cc: Michał Mirosław <mirq-linux@...e.qmqm.pl>, 
	"open list:MULTIMEDIA CARD (MMC), SECURE DIGITAL (SD) AND..." <linux-mmc@...r.kernel.org>, open list <linux-kernel@...r.kernel.org>, 
	opensource.kernel@...o.com
Subject: Re: [PATCH v1] mmc: Convert ternary operator to str_plural() helper

On Wed, 18 Jun 2025 at 14:00, Li Dong <lidong@...o.com> wrote:
>
> Replace direct ternary condition check with existing helper function
> str_plural() to improve code readability and maintain consistency.
>
> Signed-off-by: Li Dong <lidong@...o.com>

Applied for next, thanks!

Kind regards
Uffe


> ---
>  drivers/mmc/host/cb710-mmc.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/host/cb710-mmc.c b/drivers/mmc/host/cb710-mmc.c
> index d741c1f9cf87..52f9cf7dbc7f 100644
> --- a/drivers/mmc/host/cb710-mmc.c
> +++ b/drivers/mmc/host/cb710-mmc.c
> @@ -8,6 +8,7 @@
>  #include <linux/module.h>
>  #include <linux/pci.h>
>  #include <linux/delay.h>
> +#include <linux/string_choices.h>
>  #include "cb710-mmc.h"
>
>  #define CB710_MMC_REQ_TIMEOUT_MS       2000
> @@ -215,7 +216,7 @@ static void cb710_mmc_set_transfer_size(struct cb710_slot *slot,
>                 ((count - 1) << 16)|(blocksize - 1));
>
>         dev_vdbg(cb710_slot_dev(slot), "set up for %zu block%s of %zu bytes\n",
> -               count, count == 1 ? "" : "s", blocksize);
> +               count, str_plural(count), blocksize);
>  }
>
>  static void cb710_mmc_fifo_hack(struct cb710_slot *slot)
> --
> 2.39.0
>