linux-kernel - Re: [PATCH] LoongArch: Fix build warnings about export.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAAhV-H6z_56D-mcfqyD4-_TCZVvmjVb3ab0B8j_QF_Yy2X6FBw@mail.gmail.com>
Date: Thu, 19 Jun 2025 20:28:21 +0800
From: Huacai Chen <chenhuacai@...nel.org>
To: Eric Biggers <ebiggers@...nel.org>
Cc: Huacai Chen <chenhuacai@...ngson.cn>, Masahiro Yamada <masahiroy@...nel.org>, 
	linux-kbuild@...r.kernel.org, loongarch@...ts.linux.dev, 
	Guo Ren <guoren@...nel.org>, Xuerui Wang <kernel@...0n.name>, 
	Jiaxun Yang <jiaxun.yang@...goat.com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] LoongArch: Fix build warnings about export.h

Hi, Eric,

On Tue, Jun 17, 2025 at 2:57 AM Eric Biggers <ebiggers@...nel.org> wrote:
>
> On Sun, Jun 08, 2025 at 10:15:09PM +0800, Huacai Chen wrote:
> > diff --git a/arch/loongarch/lib/crc32-loongarch.c b/arch/loongarch/lib/crc32-loongarch.c
> > index b37cd8537b45..db22c2ec55e2 100644
> > --- a/arch/loongarch/lib/crc32-loongarch.c
> > +++ b/arch/loongarch/lib/crc32-loongarch.c
> > @@ -11,6 +11,7 @@
> >
> >  #include <asm/cpu-features.h>
> >  #include <linux/crc32.h>
> > +#include <linux/export.h>
> >  #include <linux/module.h>
> >  #include <linux/unaligned.h>
>
> You can drop the change to crc32-loongarch.c, as it would conflict with
> https://lore.kernel.org/r/20250601224441.778374-8-ebiggers@kernel.org/ and
> https://lore.kernel.org/r/20250612183852.114878-1-ebiggers@kernel.org/ which are
> in crc-next for 6.17 and already handle this issue.
Thank you for your suggestion. But I plan to merge this patch for
6.16, while your commits are for 6.17, I can only keep it as is.

However, the conflicts can be easily solved when Linus merges your
code, or there is an alternative solution (if you want): update your
patches when this one gets upstream.

Huacai

>
> - Eric