linux-kernel - Re: [PATCH] pinctrl: zynq: add CONFIG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAMRc=Menh3dPXbA7dJCRLRXu=FtQ19gwWLsDaWfjw=+nn2Bweg@mail.gmail.com>
Date: Fri, 20 Jun 2025 16:38:57 +0200
From: Bartosz Golaszewski <brgl@...ev.pl>
To: Arnd Bergmann <arnd@...db.de>
Cc: Arnd Bergmann <arnd@...nel.org>, Linus Walleij <linus.walleij@...aro.org>, 
	Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>, 
	Sai Krishna Potthuri <sai.krishna.potthuri@....com>, Geert Uytterhoeven <geert+renesas@...der.be>, 
	Bartosz Golaszewski <bartosz.golaszewski@...aro.org>, Pratap Nirujogi <pratap.nirujogi@....com>, 
	"open list:GPIO SUBSYSTEM" <linux-gpio@...r.kernel.org>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] pinctrl: zynq: add CONFIG_OF dependency

On Fri, Jun 20, 2025 at 3:46 PM Arnd Bergmann <arnd@...db.de> wrote:
>
> On Fri, Jun 20, 2025, at 15:36, Bartosz Golaszewski wrote:
> > On Fri, Jun 20, 2025 at 3:08 PM Arnd Bergmann <arnd@...nel.org> wrote:
>
> >> --- a/drivers/pinctrl/Kconfig
> >> +++ b/drivers/pinctrl/Kconfig
> >> @@ -603,6 +603,7 @@ config PINCTRL_TH1520
> >>  config PINCTRL_ZYNQ
> >>         bool "Pinctrl driver for Xilinx Zynq"
> >>         depends on ARCH_ZYNQ || COMPILE_TEST
> >> +       depends on OF
> >>         select PINMUX
>
> >
> > I don't think this is the actual problem. I can build (and link)
> > pinctrl-zynq with COMPILE_OF disabled alright. Can you paste the
> > entire offending .config somewhere?
>
> This is from a randconfig build: https://pastebin.com/ism57RPe
>
>      Arnd

Right. I don't have the time to look into untangling it but in general
all OF interfaces have relevant stubs so `depends on OF` should not be
needed. But it's more complex here in pinctrl so I'm fine with this
for now.

Bartosz