linux-kernel - Re: [PATCH 2/3] KVM: TDX: Handle TDG.VP.VMCALL<GetQuote>

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <afcb49f2-d881-420d-9727-58182e52f977@linux.intel.com>
Date: Fri, 20 Jun 2025 10:57:16 +0800
From: Binbin Wu <binbin.wu@...ux.intel.com>
To: Paolo Bonzini <pbonzini@...hat.com>, linux-kernel@...r.kernel.org,
 kvm@...r.kernel.org, seanjc@...gle.com
Cc: rick.p.edgecombe@...el.com, kai.huang@...el.com, adrian.hunter@...el.com,
 reinette.chatre@...el.com, xiaoyao.li@...el.com, tony.lindgren@...el.com,
 isaku.yamahata@...el.com, yan.y.zhao@...el.com,
 mikko.ylinen@...ux.intel.com, kirill.shutemov@...el.com, jiewen.yao@...el.com
Subject: Re: [PATCH 2/3] KVM: TDX: Handle TDG.VP.VMCALL<GetQuote>



On 6/20/2025 2:01 AM, Paolo Bonzini wrote:
[...]
> @@ -7174,6 +7175,52 @@ The valid value for 'flags' is:
>     - KVM_NOTIFY_CONTEXT_INVALID -- the VM context is corrupted and not valid
>       in VMCS. It would run into unknown result if resume the target VM.
>   
> +::
> +
> +		/* KVM_EXIT_TDX */
> +		struct {
> +			__u64 flags;
> +			__u64 nr;
> +			union {
> +				struct {
> +					u64 ret;
> +					u64 data[5];
Should the interface reserve more elements?

Without considering XMM registers, the possible registers according to GHCI spec
are RBX, RDX, RBP, RDI, RSI, R8, R9, R12-R15. Since RBP is not suggested to be
used to pass information, how about make the array 10 elements?


> +				} unknown;
> +				struct {
> +					u64 ret;
> +					u64 gpa;
> +					u64 size;
> +				} get_quote;
> +			};
> +		} tdx;
> +