linux-kernel - [PATCH] scripts/gdb: Fix interrupts.py after maple tree conversion

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250620181446.477246-1-florian.fainelli@broadcom.com>
Date: Fri, 20 Jun 2025 11:14:46 -0700
From: Florian Fainelli <florian.fainelli@...adcom.com>
To: linux-kernel@...r.kernel.org
Cc: Florian Fainelli <florian.fainelli@...adcom.com>,
	Jan Kiszka <jan.kiszka@...mens.com>,
	Kieran Bingham <kbingham@...nel.org>,
	Thomas Gleixner <tglx@...utronix.de>,
	Shanker Donthineni <sdonthineni@...dia.com>
Subject: [PATCH] scripts/gdb: Fix interrupts.py after maple tree conversion

In commit 721255b9826b ("genirq: Use a maple tree for interrupt
descriptor management"), the irq_desc_tree was replaced with a
sparse_irqs tree using a maple tree structure. In the interest of
providing both a minimal bugfix as well as something that is unlikely to
break in the future, invoke the irq_to_desc() function directly from
within GDB in order to obtain the interrupt number. This requires us to
handle the gdb.error exception to continue walking the tree.

Fixes: 721255b9826b ("genirq: Use a maple tree for interrupt descriptor management")
Signed-off-by: Florian Fainelli <florian.fainelli@...adcom.com>
---
 scripts/gdb/linux/interrupts.py | 14 ++++++--------
 1 file changed, 6 insertions(+), 8 deletions(-)

diff --git a/scripts/gdb/linux/interrupts.py b/scripts/gdb/linux/interrupts.py
index 616a5f26377a..81bfa09f45fb 100644
--- a/scripts/gdb/linux/interrupts.py
+++ b/scripts/gdb/linux/interrupts.py
@@ -7,7 +7,6 @@ import gdb
 from linux import constants
 from linux import cpus
 from linux import utils
-from linux import radixtree
 
 irq_desc_type = utils.CachedType("struct irq_desc")
 
@@ -23,12 +22,11 @@ def irqd_is_level(desc):
 def show_irq_desc(prec, irq):
     text = ""
 
-    desc = radixtree.lookup(gdb.parse_and_eval("&irq_desc_tree"), irq)
-    if desc is None:
-        return text
-
-    desc = desc.cast(irq_desc_type.get_type())
-    if desc is None:
+    try:
+        desc = gdb.parse_and_eval(f"irq_to_desc({irq})")
+        if desc == 0:
+            return text
+    except gdb.error:
         return text
 
     if irq_settings_is_hidden(desc):
@@ -221,7 +219,7 @@ class LxInterruptList(gdb.Command):
             gdb.write("CPU%-8d" % cpu)
         gdb.write("\n")
 
-        if utils.gdb_eval_or_none("&irq_desc_tree") is None:
+        if utils.gdb_eval_or_none("&irq_desc_tree") or utils.gdb_eval_or_none("&sparse_irqs") is None:
             return
 
         for irq in range(nr_irqs):
-- 
2.43.0