| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <IA3PR11MB89862A2FCD832C087823D3FEE57CA@IA3PR11MB8986.namprd11.prod.outlook.com>
Date: Fri, 20 Jun 2025 19:12:20 +0000
From: "Loktionov, Aleksandr" <aleksandr.loktionov@...el.com>
To: Arnd Bergmann <arnd@...nel.org>, "Nguyen, Anthony L"
<anthony.l.nguyen@...el.com>, "Kitszel, Przemyslaw"
<przemyslaw.kitszel@...el.com>, Andrew Lunn <andrew+netdev@...n.ch>, "David
S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, "Jakub
Kicinski" <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>
CC: Arnd Bergmann <arnd@...db.de>, Simon Horman <horms@...nel.org>, "Dr. David
Alan Gilbert" <linux@...blig.org>, Dawid Osuchowski
<dawid.osuchowski@...ux.intel.com>, "Jagielski, Jedrzej"
<jedrzej.jagielski@...el.com>, "Polchlopek, Mateusz"
<mateusz.polchlopek@...el.com>, "Kwapulinski, Piotr"
<piotr.kwapulinski@...el.com>, "Mrozowicz, SlawomirX"
<slawomirx.mrozowicz@...el.com>, Martyna Szapar-Mudlaw
<martyna.szapar-mudlaw@...ux.intel.com>, "intel-wired-lan@...ts.osuosl.org"
<intel-wired-lan@...ts.osuosl.org>, "netdev@...r.kernel.org"
<netdev@...r.kernel.org>, "linux-kernel@...r.kernel.org"
<linux-kernel@...r.kernel.org>
Subject: RE: [Intel-wired-lan] [PATCH] [v2] ethernet: intel: fix building with
large NR_CPUS
> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces@...osl.org> On Behalf
> Of Arnd Bergmann
> Sent: Friday, June 20, 2025 7:31 PM
> To: Nguyen, Anthony L <anthony.l.nguyen@...el.com>; Kitszel,
> Przemyslaw <przemyslaw.kitszel@...el.com>; Andrew Lunn
> <andrew+netdev@...n.ch>; David S. Miller <davem@...emloft.net>; Eric
> Dumazet <edumazet@...gle.com>; Jakub Kicinski <kuba@...nel.org>; Paolo
> Abeni <pabeni@...hat.com>
> Cc: Arnd Bergmann <arnd@...db.de>; Simon Horman <horms@...nel.org>;
> Dr. David Alan Gilbert <linux@...blig.org>; Loktionov, Aleksandr
> <aleksandr.loktionov@...el.com>; Dawid Osuchowski
> <dawid.osuchowski@...ux.intel.com>; Jagielski, Jedrzej
> <jedrzej.jagielski@...el.com>; Polchlopek, Mateusz
> <mateusz.polchlopek@...el.com>; Kwapulinski, Piotr
> <piotr.kwapulinski@...el.com>; Mrozowicz, SlawomirX
> <slawomirx.mrozowicz@...el.com>; Martyna Szapar-Mudlaw
> <martyna.szapar-mudlaw@...ux.intel.com>; intel-wired-
> lan@...ts.osuosl.org; netdev@...r.kernel.org; linux-
> kernel@...r.kernel.org
> Subject: [Intel-wired-lan] [PATCH] [v2] ethernet: intel: fix building
> with large NR_CPUS
>
> From: Arnd Bergmann <arnd@...db.de>
>
> With large values of CONFIG_NR_CPUS, three Intel ethernet drivers fail
> to compile like:
>
> In function ‘i40e_free_q_vector’,
> inlined from ‘i40e_vsi_alloc_q_vectors’ at
> drivers/net/ethernet/intel/i40e/i40e_main.c:12112:3:
> 571 | _compiletime_assert(condition, msg,
> __compiletime_assert_, __COUNTER__)
> include/linux/rcupdate.h:1084:17: note: in expansion of macro
> ‘BUILD_BUG_ON’
> 1084 | BUILD_BUG_ON(offsetof(typeof(*(ptr)), rhf) >=
> 4096); \
> drivers/net/ethernet/intel/i40e/i40e_main.c:5113:9: note: in expansion
> of macro ‘kfree_rcu’
> 5113 | kfree_rcu(q_vector, rcu);
> | ^~~~~~~~~
>
> The problem is that the 'rcu' member in 'q_vector' is too far from the
> start of the structure. Move this member before the CPU mask instead,
> in all three drivers.
>
> Signed-off-by: Arnd Bergmann <arnd@...db.de>
Reviewed-by: Aleksandr Loktionov <aleksandr.loktionov@...el.com>
> ---
> v2: move rcu to just after the napi_struct [Alexander Lobakin]
> ---
> drivers/net/ethernet/intel/fm10k/fm10k.h | 3 ++-
> drivers/net/ethernet/intel/i40e/i40e.h | 2 +-
> drivers/net/ethernet/intel/ixgbe/ixgbe.h | 3 ++-
> 3 files changed, 5 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/net/ethernet/intel/fm10k/fm10k.h
> b/drivers/net/ethernet/intel/fm10k/fm10k.h
> index 6119a4108838..65a2816142d9 100644
> --- a/drivers/net/ethernet/intel/fm10k/fm10k.h
> +++ b/drivers/net/ethernet/intel/fm10k/fm10k.h
> @@ -189,13 +189,14 @@ struct fm10k_q_vector {
> struct fm10k_ring_container rx, tx;
>
> struct napi_struct napi;
> + struct rcu_head rcu; /* to avoid race with update stats on free
> */
> +
> cpumask_t affinity_mask;
> char name[IFNAMSIZ + 9];
>
> #ifdef CONFIG_DEBUG_FS
> struct dentry *dbg_q_vector;
> #endif /* CONFIG_DEBUG_FS */
> - struct rcu_head rcu; /* to avoid race with update stats on free
> */
>
> /* for dynamic allocation of rings associated with this
> q_vector */
> struct fm10k_ring ring[] ____cacheline_internodealigned_in_smp;
> diff --git a/drivers/net/ethernet/intel/i40e/i40e.h
> b/drivers/net/ethernet/intel/i40e/i40e.h
> index 54d5fdc303ca..c429252859d3 100644
> --- a/drivers/net/ethernet/intel/i40e/i40e.h
> +++ b/drivers/net/ethernet/intel/i40e/i40e.h
> @@ -946,6 +946,7 @@ struct i40e_q_vector {
> u16 reg_idx; /* register index of the interrupt */
>
> struct napi_struct napi;
> + struct rcu_head rcu; /* to avoid race with update stats on free
> */
>
> struct i40e_ring_container rx;
> struct i40e_ring_container tx;
> @@ -956,7 +957,6 @@ struct i40e_q_vector {
> cpumask_t affinity_mask;
> struct irq_affinity_notify affinity_notify;
>
> - struct rcu_head rcu; /* to avoid race with update stats on free
> */
> char name[I40E_INT_NAME_STR_LEN];
> bool arm_wb_state;
> bool in_busy_poll;
> diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe.h
> b/drivers/net/ethernet/intel/ixgbe/ixgbe.h
> index c6772cd2d802..3f9521d4e899 100644
> --- a/drivers/net/ethernet/intel/ixgbe/ixgbe.h
> +++ b/drivers/net/ethernet/intel/ixgbe/ixgbe.h
> @@ -507,9 +507,10 @@ struct ixgbe_q_vector {
> struct ixgbe_ring_container rx, tx;
>
> struct napi_struct napi;
> + struct rcu_head rcu; /* to avoid race with update stats on free
> */
> +
> cpumask_t affinity_mask;
> int numa_node;
> - struct rcu_head rcu; /* to avoid race with update stats on free
> */
> char name[IFNAMSIZ + 9];
>
> /* for dynamic allocation of rings associated with this
> q_vector */
> --
> 2.39.5
Powered by blists - more mailing lists