linux-kernel - Re: [PATCH v5 2/3] mfd: ls2kbmc: Add Loongson-2K BMC reset function support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202506210343.XCHkzorp-lkp@intel.com>
Date: Sat, 21 Jun 2025 03:35:58 +0800
From: kernel test robot <lkp@...el.com>
To: Binbin Zhou <zhoubinbin@...ngson.cn>,
	Binbin Zhou <zhoubb.aaron@...il.com>,
	Huacai Chen <chenhuacai@...ngson.cn>, Lee Jones <lee@...nel.org>,
	Corey Minyard <minyard@....org>
Cc: oe-kbuild-all@...ts.linux.dev, Xuerui Wang <kernel@...0n.name>,
	loongarch@...ts.linux.dev, linux-kernel@...r.kernel.org,
	openipmi-developer@...ts.sourceforge.net, jeffbai@...c.io,
	kexybiscuit@...c.io, wangyao@...ote.com,
	Chong Qiao <qiaochong@...ngson.cn>
Subject: Re: [PATCH v5 2/3] mfd: ls2kbmc: Add Loongson-2K BMC reset function
 support

Hi Binbin,

kernel test robot noticed the following build errors:

[auto build test ERROR on 8ffcb7560b4a15faf821df95e3ab532b2b020f8c]

url:    https://github.com/intel-lab-lkp/linux/commits/Binbin-Zhou/mfd-ls2kbmc-Introduce-Loongson-2K-BMC-core-driver/20250620-100856
base:   8ffcb7560b4a15faf821df95e3ab532b2b020f8c
patch link:    https://lore.kernel.org/r/174677c13e41140e19a62dd01b9502aaa7fae669.1750301674.git.zhoubinbin%40loongson.cn
patch subject: [PATCH v5 2/3] mfd: ls2kbmc: Add Loongson-2K BMC reset function support
config: sh-allmodconfig (https://download.01.org/0day-ci/archive/20250621/202506210343.XCHkzorp-lkp@intel.com/config)
compiler: sh4-linux-gcc (GCC) 15.1.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250621/202506210343.XCHkzorp-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202506210343.XCHkzorp-lkp@intel.com/

All errors (new ones prefixed by >>):

   drivers/mfd/ls2k-bmc-core.c: In function 'ls2k_bmc_pcie_is_connected':
>> drivers/mfd/ls2k-bmc-core.c:156:16: error: implicit declaration of function 'pci_iomap'; did you mean 'pcim_iomap'? [-Wimplicit-function-declaration]
     156 |         base = pci_iomap(parent, 0, LS7A_PCI_CFG_SIZE);
         |                ^~~~~~~~~
         |                pcim_iomap
>> drivers/mfd/ls2k-bmc-core.c:156:14: error: assignment to 'void *' from 'int' makes pointer from integer without a cast [-Wint-conversion]
     156 |         base = pci_iomap(parent, 0, LS7A_PCI_CFG_SIZE);
         |              ^
   In file included from include/linux/io.h:12,
                    from include/linux/iopoll.h:14,
                    from drivers/mfd/ls2k-bmc-core.c:17:
>> arch/sh/include/asm/io.h:122:21: error: implicit declaration of function 'pci_iounmap'; did you mean 'pcim_iounmap'? [-Wimplicit-function-declaration]
     122 | #define pci_iounmap pci_iounmap
         |                     ^~~~~~~~~~~
   drivers/mfd/ls2k-bmc-core.c:167:17: note: in expansion of macro 'pci_iounmap'
     167 |                 pci_iounmap(parent, base);
         |                 ^~~~~~~~~~~
   drivers/mfd/ls2k-bmc-core.c: In function 'ls2k_bmc_pdata_initial':
   drivers/mfd/ls2k-bmc-core.c:350:15: error: implicit declaration of function 'acpi_register_gsi' [-Wimplicit-function-declaration]
     350 |         irq = acpi_register_gsi(NULL, gsi, ACPI_EDGE_SENSITIVE, ACPI_ACTIVE_LOW);
         |               ^~~~~~~~~~~~~~~~~
   drivers/mfd/ls2k-bmc-core.c:377:9: error: implicit declaration of function 'acpi_unregister_gsi'; did you mean 'arch_unregister_cpu'? [-Wimplicit-function-declaration]
     377 |         acpi_unregister_gsi(gsi);
         |         ^~~~~~~~~~~~~~~~~~~
         |         arch_unregister_cpu
   drivers/mfd/ls2k-bmc-core.c: At top level:
   drivers/mfd/ls2k-bmc-core.c:481:1: warning: data definition has no type or storage class
     481 | module_pci_driver(ls2k_bmc_driver);
         | ^~~~~~~~~~~~~~~~~
   drivers/mfd/ls2k-bmc-core.c:481:1: error: type defaults to 'int' in declaration of 'module_pci_driver' [-Wimplicit-int]
   drivers/mfd/ls2k-bmc-core.c:481:1: error: parameter names (without types) in function declaration [-Wdeclaration-missing-parameter-type]
   drivers/mfd/ls2k-bmc-core.c:475:26: warning: 'ls2k_bmc_driver' defined but not used [-Wunused-variable]
     475 | static struct pci_driver ls2k_bmc_driver = {
         |                          ^~~~~~~~~~~~~~~


vim +156 drivers/mfd/ls2k-bmc-core.c

   150	
   151	static bool ls2k_bmc_pcie_is_connected(struct pci_dev *parent, struct ls2k_bmc_pdata *priv)
   152	{
   153		void __iomem *base;
   154		int sts, ret;
   155	
 > 156		base = pci_iomap(parent, 0, LS7A_PCI_CFG_SIZE);
   157		if (!base)
   158			return false;
   159	
   160		writel(readl(base + LS7A_PCIE_PORT_CTL0) | LS2K_BMC_PCIE_LTSSM_ENABLE,
   161		       base + LS7A_PCIE_PORT_CTL0);
   162	
   163		ret = readl_poll_timeout_atomic(base + LS7A_PCIE_PORT_STS1, sts,
   164						(sts & LS2K_BMC_PCIE_LTSSM_STS) == LS2K_BMC_PCIE_CONNECTED,
   165						LS2K_BMC_PCIE_DELAY_US, LS2K_BMC_PCIE_TIMEOUT_US);
   166		if (ret) {
   167			pci_iounmap(parent, base);
   168			dev_err(priv->dev, "PCIE train failed status=0x%x\n", sts);
   169			return false;
   170		}
   171	
   172		pci_iounmap(parent, base);
   173		return true;
   174	}
   175	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki