linux-kernel - Re: [PATCH] crypto: sha256 - mark sha256_choose_blocks as __always

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250620202936.GA5460@quark>
Date: Fri, 20 Jun 2025 13:29:36 -0700
From: Eric Biggers <ebiggers@...nel.org>
To: Arnd Bergmann <arnd@...nel.org>
Cc: Herbert Xu <herbert@...dor.apana.org.au>,
	"David S. Miller" <davem@...emloft.net>,
	Arnd Bergmann <arnd@...db.de>, linux-crypto@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] crypto: sha256 - mark sha256_choose_blocks as
 __always_inline

On Fri, Jun 20, 2025 at 09:19:40PM +0200, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@...db.de>
> 
> When the compiler chooses to not inline sha256_choose_blocks() in
> the purgatory code, it fails to link against the missing CPU
> specific version:
> 
> x86_64-linux-ld: arch/x86/purgatory/purgatory.ro: in function `sha256_choose_blocks.part.0':
> sha256.c:(.text+0x6a6): undefined reference to `irq_fpu_usable'
> sha256.c:(.text+0x6c7): undefined reference to `sha256_blocks_arch'
> sha256.c:(.text+0x6cc): undefined reference to `sha256_blocks_simd'
> 
> Mark this function as __always_inline to prevent this, same as sha256_finup().
> 
> Fixes: ff8f037d394f ("crypto: sha256 - Use the partial block API for generic")
> Signed-off-by: Arnd Bergmann <arnd@...db.de>
> ---
> This is likely compiler specific, I found it in randconfig testing using
> gcc-9.5 on x86.
> ---
>  include/crypto/internal/sha2.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Thanks, applied to
https://git.kernel.org/pub/scm/linux/kernel/git/ebiggers/linux.git/log/?h=libcrypto-fixes

I have some additional cleanups to SHA-256 planned, which will supersede the odd
sha256_choose_blocks() thing which shouldn't have been pushed out in the first
place.  For 6.16 I'll take this straightforward fix though.

I don't think the Fixes commit you gave is quite correct.  I revised it to:

    Fixes: 5b90a779bc54 ("crypto: lib/sha256 - Add helpers for block-based shash")

I also adjusted the commit title to be consistent with what I'm planning to use
for lib/crypto changes:

    lib/crypto: sha256: Mark sha256_choose_blocks as __always_inline

Thanks!

- Eric