linux-kernel - Re: [PATCH v2] kernel/entry: Remove some redundancy checks on syscall works

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87jz56p0tl.ffs@tglx>
Date: Fri, 20 Jun 2025 23:20:22 +0200
From: Thomas Gleixner <tglx@...utronix.de>
To: Khalid Ali <khaliidcaliy@...il.com>, peterz@...radead.org, luto@...nel.org
Cc: linux-kernel@...r.kernel.org, Khalid Ali <khaliidcaliy@...il.com>
Subject: Re: [PATCH v2] kernel/entry: Remove some redundancy checks on
 syscall works

On Sun, Jun 15 2025 at 08:28, Khalid Ali wrote:

Same prefix comment as for the other patch.

> Use SYSCALL_WORK_SYSCALL_AUDIT to check if audit needs to be done
> instead of audit context for consistency to other syscall work bit
> checks.

This does not explain why this is correct. I explained it to you here:

     https://lore.kernel.org/all/87frg2q1w7.ffs@tglx

You also missed the fact that audit_syscall_entry() has yet another
check for audit context, which means there is still redundancy, right?

Thanks,

        tglx