linux-kernel - Re: [PATCH v1 2/2] dt-bindings: iio driver: Add BMP390 pressure sensor device tree binding

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ca0f85f9-3908-4c7d-add3-905e9e6f634c@kernel.org>
Date: Fri, 20 Jun 2025 07:45:42 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: liquancin.mereenamathai@...bosch.com, linux-iio@...r.kernel.org
Cc: linux-kernel@...r.kernel.org, jic23@...nel.org, dlechner@...libre.com,
 nuno.sa@...log.com, andy@...nel.org, vassilisamir@...il.com,
 marcelo.schmitt1@...il.com, javier.carrasco.cruz@...il.com,
 Xu.Zhang@...bosch.com, Maoting.Bian@...bosch.com
Subject: Re: [PATCH v1 2/2] dt-bindings: iio driver: Add BMP390 pressure
 sensor device tree binding

On 20/06/2025 06:54, liquancin.mereenamathai@...bosch.com wrote:
> From: Liquancin Mereena Mathai <liquancin.mereenamathai@...bosch.com>
> 

Please run scripts/checkpatch.pl on the patches and fix reported
warnings. After that, run also 'scripts/checkpatch.pl --strict' on the
patches and (probably) fix more warnings. Some warnings can be ignored,
especially from --strict run, but the code here looks like it needs a
fix. Feel free to get in touch if the warning is not clear.

> Signed-off-by: Liquancin Mereena Mathai <liquancin.mereenamathai@...bosch.com>

A nit, subject: drop second/last, redundant "device tree bindings". The
"dt-bindings" prefix is already stating that these are bindings.
See also:
https://elixir.bootlin.com/linux/v6.7-rc8/source/Documentation/devicetree/bindings/submitting-patches.rst#L18

And drop driver. Bindings are not for drivers.

There are several issues in the binding at first glance, but I won't
review it due to lack of testing. Look at other bindings and don't
repeat common mistakes. Just take other RECENT binding as starting point.

<form letter>
Please use scripts/get_maintainers.pl to get a list of necessary people
and lists to CC. It might happen, that command when run on an older
kernel, gives you outdated entries. Therefore please be sure you base
your patches on recent Linux kernel.

Tools like b4 or scripts/get_maintainer.pl provide you proper list of
people, so fix your workflow. Tools might also fail if you work on some
ancient tree (don't, instead use mainline) or work on fork of kernel
(don't, instead use mainline). Just use b4 and everything should be
fine, although remember about `b4 prep --auto-to-cc` if you added new
patches to the patchset.

You missed at least devicetree list (maybe more), so this won't be
tested by automated tooling. Performing review on untested code might be
a waste of time.

Please kindly resend and include all necessary To/Cc entries.
</form letter>

Best regards,
Krzysztof