linux-kernel - Re: [PATCH v2 3/3] AppArmor: add support for lsm_config_self_policy and lsm_config_system

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202506201414.tHOEthTb-lkp@intel.com>
Date: Fri, 20 Jun 2025 14:28:49 +0800
From: kernel test robot <lkp@...el.com>
To: Maxime Bélair <maxime.belair@...onical.com>,
	linux-security-module@...r.kernel.org
Cc: oe-kbuild-all@...ts.linux.dev, john.johansen@...onical.com,
	paul@...l-moore.com, jmorris@...ei.org, serge@...lyn.com,
	mic@...ikod.net, kees@...nel.org, stephen.smalley.work@...il.com,
	casey@...aufler-ca.com, takedakn@...data.co.jp,
	penguin-kernel@...ove.sakura.ne.jp, song@...nel.org,
	linux-api@...r.kernel.org, apparmor@...ts.ubuntu.com,
	linux-kernel@...r.kernel.org,
	Maxime Bélair <maxime.belair@...onical.com>
Subject: Re: [PATCH v2 3/3] AppArmor: add support for lsm_config_self_policy
 and lsm_config_system_policy

Hi Maxime,

kernel test robot noticed the following build warnings:

[auto build test WARNING on 9c32cda43eb78f78c73aee4aa344b777714e259b]

url:    https://github.com/intel-lab-lkp/linux/commits/Maxime-B-lair/Wire-up-lsm_config_self_policy-and-lsm_config_system_policy-syscalls/20250620-022714
base:   9c32cda43eb78f78c73aee4aa344b777714e259b
patch link:    https://lore.kernel.org/r/20250619181600.478038-4-maxime.belair%40canonical.com
patch subject: [PATCH v2 3/3] AppArmor: add support for lsm_config_self_policy and lsm_config_system_policy
config: x86_64-buildonly-randconfig-002-20250620 (https://download.01.org/0day-ci/archive/20250620/202506201414.tHOEthTb-lkp@intel.com/config)
compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250620/202506201414.tHOEthTb-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202506201414.tHOEthTb-lkp@intel.com/

All warnings (new ones prefixed by >>):

>> security/apparmor/apparmorfs.c:454: warning: Function parameter or struct member 'name' not described in 'aa_profile_load_ns_name'
>> security/apparmor/apparmorfs.c:454: warning: Function parameter or struct member 'name_size' not described in 'aa_profile_load_ns_name'
>> security/apparmor/apparmorfs.c:454: warning: Function parameter or struct member 'buf' not described in 'aa_profile_load_ns_name'
>> security/apparmor/apparmorfs.c:454: warning: Function parameter or struct member 'size' not described in 'aa_profile_load_ns_name'
>> security/apparmor/apparmorfs.c:454: warning: Function parameter or struct member 'ppos' not described in 'aa_profile_load_ns_name'
--
>> security/apparmor/lsm.c:1287: warning: Function parameter or struct member 'lsm_id' not described in 'apparmor_lsm_config_self_policy'
>> security/apparmor/lsm.c:1287: warning: Function parameter or struct member 'op' not described in 'apparmor_lsm_config_self_policy'
>> security/apparmor/lsm.c:1287: warning: Function parameter or struct member 'flags' not described in 'apparmor_lsm_config_self_policy'
>> security/apparmor/lsm.c:1318: warning: Function parameter or struct member 'lsm_id' not described in 'apparmor_lsm_config_system_policy'
>> security/apparmor/lsm.c:1318: warning: Function parameter or struct member 'op' not described in 'apparmor_lsm_config_system_policy'
>> security/apparmor/lsm.c:1318: warning: Function parameter or struct member 'flags' not described in 'apparmor_lsm_config_system_policy'


vim +454 security/apparmor/apparmorfs.c

   441	
   442	/**
   443	 * aa_profile_load_ns_name - load a profile into the current namespace identified by name
   444	 * @name The name of the namesapce to load the policy in. "" for root_ns
   445	 * @name_size size of @name. 0 For root ns
   446	 * @buf buffer containing the user-provided policy
   447	 * @size size of @buf
   448	 * @ppos position pointer in the file
   449	 *
   450	 * Returns: 0 on success, negative value on error
   451	 */
   452	ssize_t aa_profile_load_ns_name(char *name, size_t name_size, const void __user *buf,
   453					size_t size, loff_t *ppos)
 > 454	{
   455		struct aa_ns *ns;
   456	
   457		if (name_size == 0)
   458			ns = aa_get_ns(root_ns);
   459		else
   460			ns = aa_lookupn_ns(root_ns, name, name_size);
   461	
   462		if (!ns)
   463			return -EINVAL;
   464	
   465		int error = policy_update(AA_MAY_LOAD_POLICY | AA_MAY_REPLACE_POLICY,
   466					  buf, size, ppos, ns);
   467	
   468		aa_put_ns(ns);
   469	
   470		return error >= 0 ? 0 : error;
   471	}
   472	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki