linux-kernel - Re: [PATCH] netfilter: ipset: fix typo in hash size macro

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4497e54a-efa0-dcb5-7f37-5de8197b5496@blackhole.kfki.hu>
Date: Fri, 20 Jun 2025 08:44:33 +0200 (CEST)
From: Jozsef Kadlecsik <kadlec@...ckhole.kfki.hu>
To: RubenKelevra <rubenkelevra@...il.com>
cc: Jozsef Kadlecsik <kadlec@...filter.org>, 
    Pablo Neira Ayuso <pablo@...filter.org>, netfilter-devel@...r.kernel.org, 
    coreteam@...filter.org, netdev@...r.kernel.org, 
    linux-kernel@...r.kernel.org
Subject: Re: [PATCH] netfilter: ipset: fix typo in hash size macro

Hi,

On Thu, 19 Jun 2025, RubenKelevra wrote:

> Rename IPSET_MIMINAL_HASHSIZE → IPSET_MINIMAL_HASHSIZE in
> ip_set_hash_gen.h, matching the header typo-fix. Keep a backward-
> compat alias in the header for out-of-tree users.

I don't think there's any need to keep a backward-comptibility alias: the 
macro is absolutely internal and don't even used outside of this file.

Could you resend your patch without it?

Best regards,
Jozsef

> Signed-off-by: RubenKelevra <rubenkelevra@...il.com>
> ---
> include/linux/netfilter/ipset/ip_set_hash.h | 4 +++-
> net/netfilter/ipset/ip_set_hash_gen.h       | 4 ++--
> 2 files changed, 5 insertions(+), 3 deletions(-)
>
> diff --git a/include/linux/netfilter/ipset/ip_set_hash.h b/include/linux/netfilter/ipset/ip_set_hash.h
> index 838abab672af1..4f7ce4eff5815 100644
> --- a/include/linux/netfilter/ipset/ip_set_hash.h
> +++ b/include/linux/netfilter/ipset/ip_set_hash.h
> @@ -6,7 +6,9 @@
>
>
> #define IPSET_DEFAULT_HASHSIZE		1024
> -#define IPSET_MIMINAL_HASHSIZE		64
> +#define IPSET_MINIMAL_HASHSIZE		64
> +/* Legacy alias for the old typo – keep until v6.1 LTS (EOL: 2027-12-31) */
> +#define IPSET_MIMINAL_HASHSIZE		IPSET_MINIMAL_HASHSIZE
> #define IPSET_DEFAULT_MAXELEM		65536
> #define IPSET_DEFAULT_PROBES		4
> #define IPSET_DEFAULT_RESIZE		100
> diff --git a/net/netfilter/ipset/ip_set_hash_gen.h b/net/netfilter/ipset/ip_set_hash_gen.h
> index 5251524b96afa..785d109645fed 100644
> --- a/net/netfilter/ipset/ip_set_hash_gen.h
> +++ b/net/netfilter/ipset/ip_set_hash_gen.h
> @@ -1543,8 +1543,8 @@ IPSET_TOKEN(HTYPE, _create)(struct net *net, struct ip_set *set,
>
> 	if (tb[IPSET_ATTR_HASHSIZE]) {
> 		hashsize = ip_set_get_h32(tb[IPSET_ATTR_HASHSIZE]);
> -		if (hashsize < IPSET_MIMINAL_HASHSIZE)
> -			hashsize = IPSET_MIMINAL_HASHSIZE;
> +		if (hashsize < IPSET_MINIMAL_HASHSIZE)
> +			hashsize = IPSET_MINIMAL_HASHSIZE;
> 	}
>
> 	if (tb[IPSET_ATTR_MAXELEM])
> -- 
> 2.49.0
>
>