linux-kernel - Re: [PATCH] HID: appletb-kbd: fix "appletb_backlight" backlight device reference counting

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <241po3rp-45q2-0pps-n724-9q87o86r4s69@xreary.bet>
Date: Fri, 20 Jun 2025 09:01:53 +0200 (CEST)
From: Jiri Kosina <jikos@...nel.org>
To: Qasim Ijaz <qasdev00@...il.com>
cc: bentiss@...nel.org, gargaditya08@...e.com, linux-input@...r.kernel.org, 
    linux-kernel@...r.kernel.org, stable@...r.kernel.org
Subject: Re: [PATCH] HID: appletb-kbd: fix "appletb_backlight" backlight
 device reference counting

On Sun, 15 Jun 2025, Qasim Ijaz wrote:

> During appletb_kbd_probe, probe attempts to get the backlight device
> by name. When this happens backlight_device_get_by_name looks for a
> device in the backlight class which has name "appletb_backlight" and
> upon finding a match it increments the reference count for the device
> and returns it to the caller. However this reference is never released 
> leading to a reference leak.
> 
> Fix this by decrementing the backlight device reference count on removal
> via put_device and on probe failure.
> 
> Fixes: 93a0fc489481 ("HID: hid-appletb-kbd: add support for automatic brightness control while using the touchbar")
> Cc: stable@...r.kernel.org
> Signed-off-by: Qasim Ijaz <qasdev00@...il.com>

Applied, thanks.

-- 
Jiri Kosina
SUSE Labs