linux-kernel - Re: [PATCH][next] HID: uclogic: make read-only array reconnect

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <r9n8r361-231r-5p3n-5377-83pp55662312@xreary.bet>
Date: Fri, 20 Jun 2025 09:06:12 +0200 (CEST)
From: Jiri Kosina <jikos@...nel.org>
To: Colin Ian King <colin.i.king@...il.com>
cc: Benjamin Tissoires <bentiss@...nel.org>, linux-input@...r.kernel.org, 
    kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH][next] HID: uclogic: make read-only array reconnect_event
 static const

On Thu, 19 Jun 2025, Colin Ian King wrote:

> Don't populate the read-only array reconnect_event on the stack
> at run time, instead make it static const.
> 
> Signed-off-by: Colin Ian King <colin.i.king@...il.com>
> ---
>  drivers/hid/hid-uclogic-params.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/hid/hid-uclogic-params.c b/drivers/hid/hid-uclogic-params.c
> index a6044996abf2..b3d56057cec9 100644
> --- a/drivers/hid/hid-uclogic-params.c
> +++ b/drivers/hid/hid-uclogic-params.c
> @@ -1341,7 +1341,7 @@ static int uclogic_params_ugee_v2_init_event_hooks(struct hid_device *hdev,
>  						   struct uclogic_params *p)
>  {
>  	struct uclogic_raw_event_hook *event_hook;
> -	__u8 reconnect_event[] = {
> +	static const __u8 reconnect_event[] = {
>  		/* Event received on wireless tablet reconnection */
>  		0x02, 0xF8, 0x02, 0x01, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00

Good catch. Applied, thanks.

-- 
Jiri Kosina
SUSE Labs