linux-kernel - Re: [PATCH v4 1/2] dt-bindings: net: bluetooth: nxp: Add support for 4M baudrate

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250620-colossal-competent-turaco-d4f8b5@kuoka>
Date: Fri, 20 Jun 2025 09:17:34 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Neeraj Sanjay Kale <neeraj.sanjaykale@....com>
Cc: marcel@...tmann.org, luiz.dentz@...il.com, robh@...nel.org, 
	krzk+dt@...nel.org, conor+dt@...nel.org, linux-bluetooth@...r.kernel.org, 
	linux-kernel@...r.kernel.org, devicetree@...r.kernel.org, amitkumar.karwar@....com, 
	sherry.sun@....com, manjeet.gupta@....com
Subject: Re: [PATCH v4 1/2] dt-bindings: net: bluetooth: nxp: Add support for
 4M baudrate

On Thu, Jun 19, 2025 at 04:46:28PM GMT, Neeraj Sanjay Kale wrote:
> Add support for 4000000 as secondary baudrate.
> 
> Signed-off-by: Neeraj Sanjay Kale <neeraj.sanjaykale@....com>
> ---
> v2: Use the available 'max-speed' device tree property. (Krzysztof)
> v3: No Change
> v4: Add ref for max-speed. (Krzysztof)

No, why?

> ---
>  .../devicetree/bindings/net/bluetooth/nxp,88w8987-bt.yaml | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/net/bluetooth/nxp,88w8987-bt.yaml b/Documentation/devicetree/bindings/net/bluetooth/nxp,88w8987-bt.yaml
> index 3ab60c70286f..bb9ab5dd3b4a 100644
> --- a/Documentation/devicetree/bindings/net/bluetooth/nxp,88w8987-bt.yaml
> +++ b/Documentation/devicetree/bindings/net/bluetooth/nxp,88w8987-bt.yaml
> @@ -34,6 +34,13 @@ properties:
>        This property depends on the module vendor's
>        configuration.
>  
> +  max-speed:
> +    $ref: /schemas/types.yaml#/definitions/uint32

No, drop, I did not ask that.

I asked to do like other bindings, just look at them. I gave you exact
ref which is missing.

NAK

Best regards,
Krzysztof