linux-kernel - Re: [RFC PATCH 1/3] media: dt-bindings: Add regulator current load

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <96ee2939-d0d6-439e-bde4-1e5476214c5a@kernel.org>
Date: Fri, 20 Jun 2025 10:35:16 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Wenmeng Liu <quic_wenmliu@...cinc.com>, rfoss@...nel.org,
 todor.too@...il.com, bryan.odonoghue@...aro.org, mchehab@...nel.org,
 robh@...nel.org, krzk+dt@...nel.org, conor+dt@...nel.org,
 andersson@...nel.org, konradybcio@...nel.org, akapatra@...cinc.com,
 hariramp@...cinc.com
Cc: linux-media@...r.kernel.org, linux-arm-msm@...r.kernel.org,
 devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
 quic_svankada@...cinc.com, quic_depengs@...cinc.com,
 quic_vikramsa@...cinc.com
Subject: Re: [RFC PATCH 1/3] media: dt-bindings: Add regulator current load

On 20/06/2025 06:07, Wenmeng Liu wrote:
> Add regulator current load support for vdda-phy vdda-pll.
> 
> Signed-off-by: Wenmeng Liu <quic_wenmliu@...cinc.com>
> ---
>  .../devicetree/bindings/media/qcom,sc7280-camss.yaml        | 6 ++++++
>  1 file changed, 6 insertions(+)
> 

This patch fails on so many levels... do internal reviews first.

Use existing properties, see regulators. If not, use existing unit
suffixes. Otherwise it is just another downstream property you send us,
to which we responded many times - don't.

Please use subject prefixes matching the subsystem. You can get them for
example with `git log --oneline -- DIRECTORY_OR_FILE` on the directory
your patch is touching. For bindings, the preferred subjects are
explained here:
https://www.kernel.org/doc/html/latest/devicetree/bindings/submitting-patches.html#i-for-patch-submitters

Read meeting notes from internal discussions where you discussed this
already.

Best regards,
Krzysztof