linux-kernel - Re: [PATCH 09/11] power: supply: qcom

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <DAR8L6C8LIOH.A6EGWUZJ2NN4@fairphone.com>
Date: Fri, 20 Jun 2025 11:01:21 +0200
From: "Luca Weiss" <luca.weiss@...rphone.com>
To: "Casey Connolly" <casey.connolly@...aro.org>, "Sebastian Reichel"
 <sre@...nel.org>, "Rob Herring" <robh@...nel.org>, "Krzysztof Kozlowski"
 <krzk+dt@...nel.org>, "Conor Dooley" <conor+dt@...nel.org>, "Bjorn
 Andersson" <andersson@...nel.org>, "Konrad Dybcio"
 <konradybcio@...nel.org>, "Kees Cook" <kees@...nel.org>, "Gustavo A. R.
 Silva" <gustavoars@...nel.org>
Cc: <linux-arm-msm@...r.kernel.org>, <linux-pm@...r.kernel.org>,
 <devicetree@...r.kernel.org>, <linux-kernel@...r.kernel.org>, "Sebastian
 Reichel" <sebastian.reichel@...labora.com>,
 <linux-hardening@...r.kernel.org>
Subject: Re: [PATCH 09/11] power: supply: qcom_smbx: add smb5 support

On Thu Jun 19, 2025 at 4:55 PM CEST, Casey Connolly wrote:
> Introduce support for the SMB5 charger found on pm8150b and other more
> modern Qualcomm SoCs.
>
> SMB5 is largely similar to SMB2, with a few register differences. The
> main difference is the new Type-C hardware block which some registers
> are moved to.
>
> Signed-off-by: Casey Connolly <casey.connolly@...aro.org>
> ---

<snip>

> +static int smb_get_prop_health(struct smb_chip *chip, int *val)
> +{
> +	switch (chip->gen) {
> +	case SMB2:
> +		return smb2_get_prop_health(chip, val);
> +	case SMB5:
> +		return smb5_get_prop_health(chip, val);
> +	}
> +}

This doesn't compile for me:

drivers/power/supply/qcom_smbx.c: In function 'smb_get_prop_health':
drivers/power/supply/qcom_smbx.c:588:1: error: control reaches end of non-void function [-Werror=return-type]
  588 | }
      | ^

Regards
Luca