linux-kernel - Re: [PATCH] Revert "regulator: tps65219: Add TI TPS65214 Regulator Support"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1cee7d78-247b-4ae3-a2d5-f478dac1985b@ti.com>
Date: Thu, 19 Jun 2025 19:15:10 -0500
From: Shree Ramamoorthy <s-ramamoorthy@...com>
To: Robert Nelson <robertcnelson@...il.com>
CC: Dhruva Gole <d-gole@...com>, <lgirdwood@...il.com>, <broonie@...nel.org>,
        <aaro.koskinen@....fi>, <andreas@...nade.info>, <khilman@...libre.com>,
        <rogerq@...nel.org>, <tony@...mide.com>, <linux-omap@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>, <m-leonard@...com>, <praneeth@...com>
Subject: Re: [PATCH] Revert "regulator: tps65219: Add TI TPS65214 Regulator
 Support"

Hi Robert,

On 6/19/2025 6:24 PM, Robert Nelson wrote:
> On Thu, Jun 19, 2025 at 2:58 PM Shree Ramamoorthy <s-ramamoorthy@...com> wrote:
>> Hi,
>>
>> On 6/19/25 10:35 AM, Dhruva Gole wrote:
>>> This reverts commit f1471bc435afa31c8c0c58551922830dc8f4b06b.
>> I will be sending a patch soon with a fix regarding the devm_kmalloc use in the probe() function.
>> I'll keep looking into these bugs to see if there's anything else to fix.

I submitted a patch that addresses the incorrect kmalloc size occurring
in the regulator probe().

When ya'll have time, could you verify if this patch [0] addresses the
boot failure you're encountering.

Regardless, this is a logic error that should be updated. Thank you for
your time & sorry for the headache this caused!

[0]:
https://lore.kernel.org/all/20250620000924.2636542-1-s-ramamoorthy@ti.com/

>>
>>> This was causing boot regressions [1] on many BeagleBoard platforms
>>> like the AM62x based BeaglePlay and PocketBeagle-2.
>>>
>>> [1] https://gist.github.com/DhruvaG2000/75b7d5ced6c09d508ee0ad5ab1f19707
> This bug is nasty... ugh! My BeaglePlay (am62) just triggered the same
> classic bug on startup.  Seems like it's related to the phase of the
> moon/etc.. Something in the PMIC doesn't like what we are doing with
> the new devices bolted on top..
>
> Here is my boot log with only f1471bc435afa31c8c0c58551922830dc8f4b06b
> reverted https://gist.github.com/RobertCNelson/745bc4f9e219be264722b2093ef03fa8
>
> So there's been 4 patches on "tps65219-regulator.c" :
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/log/drivers/regulator/tps65219-regulator.c?h=v6.16-rc2
>
> f1471bc435afa31c8c0c58551922830dc8f4b06b regulator: tps65219: Add TI
> TPS65214 Regulator Support
> 38c9f98db20a649a1f8454f507608b6aef0c9297 regulator: tps65219: Add
> support for TPS65215 Regulator IRQs
> 3f2e457efdad5af4164f155bd7ac902258a9b1ce regulator: tps65219: Add
> support for TPS65215 regulator resources
> 8c04144e156b49980a786e80c855e41f6c71685c regulator: tps65219: Update
> struct names
>
> Back to retesting the 3 other commits tomorrow!
>
> Fun note... I'm testing 4 PocketBeagle2 's and 2 BeaglePlays,
> depending on the day one board will trigger this bug 80% of the time,
> someday it takes hours to trigger.
>
> Regards,
>