linux-kernel - Re: [PATCH net] net: vlan: fix format-truncation warnings in? register_vlan

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <202506200933159890YBbryukmf_-JVQoEtvF8@zte.com.cn>
Date: Fri, 20 Jun 2025 09:33:15 +0800 (CST)
From: <jiang.peng9@....com.cn>
To: <horms@...nel.org>
Cc: <pabeni@...hat.com>, <davem@...emloft.net>, <edumazet@...gle.com>,
        <kuba@...nel.org>, <jiri@...nulli.us>, <linux@...blig.org>,
        <oscmaes92@...il.com>, <netdev@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>, <xu.xin16@....com.cn>,
        <yang.yang29@....com.cn>
Subject: Re: [PATCH net] net: vlan: fix format-truncation warnings in? register_vlan_device

> name is passed to alloc_netdev(). Which is a wrapper around alloc_netdev_mqs()
> which includes the following check:
>
>     BUG_ON(strlen(name) >= sizeof(dev->name));
>
> And the size of dev->name is IFNAMSIZ.
>
> So while I am very pleased to see efforts to address format-truncation
> warning - indeed I have made efforts elsewhere to this end myself - I don't
> think we can solve this problem the way you propose.

Thanks for pointing this out! After checking the code again, you're absolutely right - my proposed change could actually cause issues with alloc_netdev_mqs() since the BUG_ON check explicitly enforces the IFNAMSIZ limit.

It's unfortunate that we can't solve the warning this way, but I really appreciate you taking the time to explain the situation clearly. Your patience and attention to detail here are super helpful!

> Also, I suspect any work in this area will not be a bug fix, and
> thus more appropriate to target at net-next rather than net.
>
>     Subject; [PATCH net-next]
>
> And please make sure patches for net or next-next apply against
> their target tree: this patch applies to cleanly to neither.
>
> For more information on process for networking patches please see
> https://docs.kernel.org/process/maintainer-netdev.html

Got it! Thanks again for your guidance on this - I really appreciate you taking the time to explain both the technical details and the proper submission process.

Best regards
Peng