linux-kernel - Re: [PATCH v2] xen/xenbus: fix W=1 build warning in xenbus_va_dev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <62eb6d8a-7759-46b1-b06b-e7c6bc4f9a11@suse.com>
Date: Fri, 20 Jun 2025 11:50:08 +0200
From: Jürgen Groß <jgross@...e.com>
To: jiang.peng9@....com.cn
Cc: sstabellini@...nel.org, oleksandr_tyshchenko@...m.com,
 xen-devel@...ts.xenproject.org, linux-kernel@...r.kernel.org,
 xu.xin16@....com.cn, yang.yang29@....com.cn
Subject: Re: [PATCH v2] xen/xenbus: fix W=1 build warning in
 xenbus_va_dev_error function

On 20.06.25 02:41, jiang.peng9@....com.cn wrote:
> From: Peng Jiang <jiang.peng9@....com.cn>
> 
> This patch fixes a W=1 format-string warning reported by GCC 12.3.0
> by annotating xenbus_switch_fatal() and xenbus_va_dev_error()
> with the __printf attribute. The attribute enables compile-time
> validation of printf-style format strings in these functions.
> 
> The original warning trace:
> drivers/xen/xenbus/xenbus_client.c:304:9: warning: function 'xenbus_va_dev_error' might be
> a candidate for 'gnu_printf' format attribute [-Wsuggest-attribute=format]
> 
> Signed-off-by: Peng Jiang <jiang.peng9@....com.cn>

Reviewed-by: Juergen Gross <jgross@...e.com>


Juergen

PS: Next time please don't send another version of a patch as a reply,
     but as a new email thread.

Download attachment "OpenPGP_0xB0DE9DD628BF132F.asc" of type "application/pgp-keys" (3684 bytes)

Download attachment "OpenPGP_signature.asc" of type "application/pgp-signature" (496 bytes)