linux-kernel - Re: [PATCH net-next] ethtool: pse-pd: Add missing linux/export.h include

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250620101452.GE194429@horms.kernel.org>
Date: Fri, 20 Jun 2025 11:14:52 +0100
From: Simon Horman <horms@...nel.org>
To: Kory Maincent <kory.maincent@...tlin.com>
Cc: netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
	kernel test robot <lkp@...el.com>, thomas.petazzoni@...tlin.com,
	Oleksij Rempel <o.rempel@...gutronix.de>,
	Andrew Lunn <andrew@...n.ch>, Jakub Kicinski <kuba@...nel.org>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>, Paolo Abeni <pabeni@...hat.com>
Subject: Re: [PATCH net-next] ethtool: pse-pd: Add missing linux/export.h
 include

On Thu, Jun 19, 2025 at 06:25:47PM +0200, Kory Maincent wrote:
> Fix missing linux/export.h header include in net/ethtool/pse-pd.c to resolve
> build warning reported by the kernel test robot.
> 
> Reported-by: kernel test robot <lkp@...el.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202506200024.T3O0FWeR-lkp@intel.com/
> Signed-off-by: Kory Maincent <kory.maincent@...tlin.com>

Hi Kory, all,

The change that introduced this warning introduced a log of such warnings.
Including a lot in the Networking subsystem. (I did not count them.)

So I agree with the point from Sean Christopherson [*] is that if the patch
that introduced the warnings isn't reverted then a more comprehensive
approach is needed to address these warnings.

[*] Re: [PATCH 3/6] KVM: x86: hyper-v: Fix warnings for missing export.h header inclusion
    https://lore.kernel.org/netdev/aEl9kO81-kp0hhw0@google.com/