linux-kernel - RE: [Intel-wired-lan] [PATCH iwl-next, v3 1/2] igc: Relocate RSS field definitions to igc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <IA3PR11MB8986E8534B00D2B3D17C7861E57CA@IA3PR11MB8986.namprd11.prod.outlook.com>
Date: Fri, 20 Jun 2025 10:24:35 +0000
From: "Loktionov, Aleksandr" <aleksandr.loktionov@...el.com>
To: "Song, Yoong Siang" <yoong.siang.song@...el.com>, "Nguyen, Anthony L"
	<anthony.l.nguyen@...el.com>, "David S . Miller" <davem@...emloft.net>, "Eric
 Dumazet" <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, Paolo Abeni
	<pabeni@...hat.com>, Richard Cochran <richardcochran@...il.com>, "Alexei
 Starovoitov" <ast@...nel.org>, Daniel Borkmann <daniel@...earbox.net>, Jesper
 Dangaard Brouer <hawk@...nel.org>, John Fastabend <john.fastabend@...il.com>,
	"Gomes, Vinicius" <vinicius.gomes@...el.com>, Jonathan Corbet
	<corbet@....net>, "Kitszel, Przemyslaw" <przemyslaw.kitszel@...el.com>,
	Shinas Rasheed <srasheed@...vell.com>, "Tian, Kevin" <kevin.tian@...el.com>,
	Brett Creeley <brett.creeley@....com>, "Blanco Alcaine, Hector"
	<hector.blanco.alcaine@...el.com>, "Hay, Joshua A" <joshua.a.hay@...el.com>,
	Andrew Lunn <andrew+netdev@...n.ch>, "Keller, Jacob E"
	<jacob.e.keller@...el.com>, Kurt Kanzenbach <kurt@...utronix.de>, "Marcin
 Szycik" <marcin.szycik@...ux.intel.com>, Brett Creeley <bcreeley@....com>
CC: "intel-wired-lan@...ts.osuosl.org" <intel-wired-lan@...ts.osuosl.org>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [Intel-wired-lan] [PATCH iwl-next, v3 1/2] igc: Relocate RSS
 field definitions to igc_defines.h



> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces@...osl.org> On Behalf
> Of Song Yoong Siang
> Sent: Friday, June 20, 2025 12:03 PM
> To: Nguyen, Anthony L <anthony.l.nguyen@...el.com>; David S . Miller
> <davem@...emloft.net>; Eric Dumazet <edumazet@...gle.com>; Jakub
> Kicinski <kuba@...nel.org>; Paolo Abeni <pabeni@...hat.com>; Richard
> Cochran <richardcochran@...il.com>; Alexei Starovoitov
> <ast@...nel.org>; Daniel Borkmann <daniel@...earbox.net>; Jesper
> Dangaard Brouer <hawk@...nel.org>; John Fastabend
> <john.fastabend@...il.com>; Gomes, Vinicius
> <vinicius.gomes@...el.com>; Jonathan Corbet <corbet@....net>; Kitszel,
> Przemyslaw <przemyslaw.kitszel@...el.com>; Shinas Rasheed
> <srasheed@...vell.com>; Tian, Kevin <kevin.tian@...el.com>; Brett
> Creeley <brett.creeley@....com>; Blanco Alcaine, Hector
> <hector.blanco.alcaine@...el.com>; Hay, Joshua A
> <joshua.a.hay@...el.com>; Andrew Lunn <andrew+netdev@...n.ch>; Keller,
> Jacob E <jacob.e.keller@...el.com>; Kurt Kanzenbach
> <kurt@...utronix.de>; Marcin Szycik <marcin.szycik@...ux.intel.com>;
> Brett Creeley <bcreeley@....com>
> Cc: intel-wired-lan@...ts.osuosl.org; netdev@...r.kernel.org; linux-
> kernel@...r.kernel.org
> Subject: [Intel-wired-lan] [PATCH iwl-next, v3 1/2] igc: Relocate RSS
> field definitions to igc_defines.h
> 
> Move the RSS field definitions related to IPv4 and IPv6 UDP from igc.h
> to igc_defines.h to consolidate the RSS field definitions in a single
> header file, improving code organization and maintainability.
> 
> This refactoring does not alter the functionality of the driver but
> enhances the logical grouping of related constants
> 
> Reviewed-by: Kurt Kanzenbach <kurt@...utronix.de>
> Signed-off-by: Song Yoong Siang <yoong.siang.song@...el.com>
Reviewed-by: Aleksandr Loktionov <aleksandr.loktionov@...el.com>
> ---
>  drivers/net/ethernet/intel/igc/igc.h         | 4 ----
>  drivers/net/ethernet/intel/igc/igc_defines.h | 3 +++
>  2 files changed, 3 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/net/ethernet/intel/igc/igc.h
> b/drivers/net/ethernet/intel/igc/igc.h
> index 1525ae25fd3e..0b35e593d5ee 100644
> --- a/drivers/net/ethernet/intel/igc/igc.h
> +++ b/drivers/net/ethernet/intel/igc/igc.h
> @@ -406,10 +406,6 @@ extern char igc_driver_name[];
>  #define IGC_FLAG_RSS_FIELD_IPV4_UDP	BIT(6)
>  #define IGC_FLAG_RSS_FIELD_IPV6_UDP	BIT(7)
> 
> -#define IGC_MRQC_ENABLE_RSS_MQ		0x00000002
> -#define IGC_MRQC_RSS_FIELD_IPV4_UDP	0x00400000
> -#define IGC_MRQC_RSS_FIELD_IPV6_UDP	0x00800000
> -
>  /* RX-desc Write-Back format RSS Type's */  enum igc_rss_type_num {
>  	IGC_RSS_TYPE_NO_HASH		= 0,
> diff --git a/drivers/net/ethernet/intel/igc/igc_defines.h
> b/drivers/net/ethernet/intel/igc/igc_defines.h
> index 86b346687196..d80254f2a278 100644
> --- a/drivers/net/ethernet/intel/igc/igc_defines.h
> +++ b/drivers/net/ethernet/intel/igc/igc_defines.h
> @@ -383,11 +383,14 @@
>  #define IGC_RXDEXT_STATERR_IPE		0x40000000
>  #define IGC_RXDEXT_STATERR_RXE		0x80000000
> 
> +#define IGC_MRQC_ENABLE_RSS_MQ		0x00000002
>  #define IGC_MRQC_RSS_FIELD_IPV4_TCP	0x00010000
>  #define IGC_MRQC_RSS_FIELD_IPV4		0x00020000
>  #define IGC_MRQC_RSS_FIELD_IPV6_TCP_EX	0x00040000
>  #define IGC_MRQC_RSS_FIELD_IPV6		0x00100000
>  #define IGC_MRQC_RSS_FIELD_IPV6_TCP	0x00200000
> +#define IGC_MRQC_RSS_FIELD_IPV4_UDP	0x00400000
> +#define IGC_MRQC_RSS_FIELD_IPV6_UDP	0x00800000
> 
>  /* Header split receive */
>  #define IGC_RFCTL_IPV6_EX_DIS	0x00010000
> --
> 2.34.1