linux-kernel - Re: [PATCH] pinctrl: zynq: add CONFIG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAMRc=Mep0SNj6anWcmaNh4v8Z=J7eomujU69Gz_exuG2Wsd=8A@mail.gmail.com>
Date: Fri, 20 Jun 2025 15:36:53 +0200
From: Bartosz Golaszewski <brgl@...ev.pl>
To: Arnd Bergmann <arnd@...nel.org>
Cc: Linus Walleij <linus.walleij@...aro.org>, 
	Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>, 
	Sai Krishna Potthuri <sai.krishna.potthuri@....com>, Arnd Bergmann <arnd@...db.de>, 
	Geert Uytterhoeven <geert+renesas@...der.be>, 
	Bartosz Golaszewski <bartosz.golaszewski@...aro.org>, Pratap Nirujogi <pratap.nirujogi@....com>, 
	linux-gpio@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] pinctrl: zynq: add CONFIG_OF dependency

On Fri, Jun 20, 2025 at 3:08 PM Arnd Bergmann <arnd@...nel.org> wrote:
>
> From: Arnd Bergmann <arnd@...db.de>
>
> The zynq driver can be enabled for compile-testing on builds without
> CONFIG_OF, leading to a link error:
>
> ld.lld-21: error: undefined symbol: pinconf_generic_dt_node_to_map
>  referenced by pinconf-generic.h:231 (/home/arnd/arm-soc/include/linux/pinctrl/pinconf-generic.h:231)
>           drivers/pinctrl/pinctrl-zynq.o:(pinconf_generic_dt_node_to_map_all) in archive vmlinux.a
>
> Prevent this with the proper compile time dependency.
>
> Fixes: 1982621decaf ("pinctrl: Allow compile testing for K210, TB10X and ZYNQ")
> Signed-off-by: Arnd Bergmann <arnd@...db.de>
> ---
>  drivers/pinctrl/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/pinctrl/Kconfig b/drivers/pinctrl/Kconfig
> index 753692e9ecf5..ddd11668457c 100644
> --- a/drivers/pinctrl/Kconfig
> +++ b/drivers/pinctrl/Kconfig
> @@ -603,6 +603,7 @@ config PINCTRL_TH1520
>  config PINCTRL_ZYNQ
>         bool "Pinctrl driver for Xilinx Zynq"
>         depends on ARCH_ZYNQ || COMPILE_TEST
> +       depends on OF
>         select PINMUX
>         select GENERIC_PINCONF
>         help
> --
> 2.39.5
>
>

I don't think this is the actual problem. I can build (and link)
pinctrl-zynq with COMPILE_OF disabled alright. Can you paste the
entire offending .config somewhere?

Bartosz