linux-kernel - Re: [PATCH V2] exfat: fdatasync flag should be same like generic_write

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAKYAXd_aBgCwmrS6FjaDRBxSGvOxB8t4XdxJ+Qf8x=quu4Yv=g@mail.gmail.com>
Date: Fri, 20 Jun 2025 22:50:10 +0900
From: Namjae Jeon <linkinjeon@...nel.org>
To: Zhengxu Zhang <zhengxu.zhang@...soc.com>
Cc: sj1557.seo@...sung.com, Yuezhang.Mo@...y.com, 
	linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org, 
	cixi.geng@...ux.dev, hao_hao.wang@...soc.com, zhiguo.niu@...soc.com
Subject: Re: [PATCH V2] exfat: fdatasync flag should be same like generic_write_sync()

On Thu, Jun 19, 2025 at 10:34 AM Zhengxu Zhang <zhengxu.zhang@...soc.com> wrote:
>
> Test: androbench by default setting, use 64GB sdcard.
>  the random write speed:
>         without this patch 3.5MB/s
>         with this patch 7MB/s
>
> After patch "11a347fb6cef", the random write speed decreased significantly.
> the .write_iter() interface had been modified, and check the differences with
> generic_file_write_iter(), when calling generic_write_sync() and
> exfat_file_write_iter() to call vfs_fsync_range(), the fdatasync flag is wrong,
> and make not use the fdatasync mode, and make random write speed decreased.
>
> So use generic_write_sync() instead of vfs_fsync_range().
>
> Fixes: 11a347fb6cef ("exfat: change to get file size from DataLength")
>
> Signed-off-by: Zhengxu Zhang <zhengxu.zhang@...soc.com>
Applied it to #dev.
Thanks!