linux-kernel - Re: [PATCH V2 1/5] panic: clean up code for console replay

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aFVt4XBFArtFvPRh@pathway.suse.cz>
Date: Fri, 20 Jun 2025 16:19:13 +0200
From: Petr Mladek <pmladek@...e.com>
To: Feng Tang <feng.tang@...ux.alibaba.com>
Cc: Andrew Morton <akpm@...ux-foundation.org>,
	Steven Rostedt <rostedt@...dmis.org>,
	Lance Yang <lance.yang@...ux.dev>, Jonathan Corbet <corbet@....net>,
	linux-kernel@...r.kernel.org, paulmck@...nel.org,
	john.ogness@...utronix.de
Subject: Re: [PATCH V2 1/5] panic: clean up code for console replay

On Mon 2025-06-16 09:08:36, Feng Tang wrote:
> Currently the panic_print_sys_info() was called twice with different
> parameters to handle console replay case, which is kind of confusing.
> 
> Add panic_console_replay() explicitly to make the code straightforward.
> 
> Suggested-by: Petr Mladek <pmladek@...e.com>
> Signed-off-by: Feng Tang <feng.tang@...ux.alibaba.com>

Looks good to me:

Reviewed-by: Petr Mladek <pmladek@...e.com>

Best Regards,
Petr