linux-kernel - Re: [PATCH 3/4] tools/nolibc: move FD

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <25eb3144-d19e-43d2-af4f-b0251d28808c@t-8ch.de>
Date: Sat, 21 Jun 2025 10:21:47 +0200
From: Thomas Weißschuh <linux@...ssschuh.net>
To: Willy Tarreau <w@....eu>
Cc: Thomas Weißschuh <thomas.weissschuh@...utronix.de>, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 3/4] tools/nolibc: move FD_* definitions to sys/select.h

On 2025-06-20 12:02:50+0200, Willy Tarreau wrote:
> Modern programs tend to include sys/select.h to get FD_SET() and
> FD_CLR() definitions as well as struct fd_set, but in our case it
> didn't exist. Let's move these definitions from types.h to sys/select.h
> to help port existing programs.
> 
> Signed-off-by: Willy Tarreau <w@....eu>

<snip>

> diff --git a/tools/include/nolibc/types.h b/tools/include/nolibc/types.h
> index 16c6e9ec9451f..0b51ede4e0a9c 100644
> --- a/tools/include/nolibc/types.h
> +++ b/tools/include/nolibc/types.h
> @@ -10,6 +10,7 @@
>  #ifndef _NOLIBC_TYPES_H
>  #define _NOLIBC_TYPES_H
>  
> +#include "sys/select.h"

Is this really necessary?

>  #include "std.h"
>  #include <linux/mman.h>
>  #include <linux/stat.h>
> @@ -70,11 +71,6 @@
>  #define DT_LNK         0xa
>  #define DT_SOCK        0xc

<snip>