linux-kernel - Re: [Patch v4 09/13] perf/x86/intel: Setup PEBS data configuration and enable legacy groups

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250621093638.GW1613376@noisy.programming.kicks-ass.net>
Date: Sat, 21 Jun 2025 11:36:38 +0200
From: Peter Zijlstra <peterz@...radead.org>
To: Dapeng Mi <dapeng1.mi@...ux.intel.com>
Cc: Ingo Molnar <mingo@...hat.com>,
	Arnaldo Carvalho de Melo <acme@...nel.org>,
	Namhyung Kim <namhyung@...nel.org>, Ian Rogers <irogers@...gle.com>,
	Adrian Hunter <adrian.hunter@...el.com>,
	Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
	Kan Liang <kan.liang@...ux.intel.com>,
	Andi Kleen <ak@...ux.intel.com>,
	Eranian Stephane <eranian@...gle.com>, linux-kernel@...r.kernel.org,
	linux-perf-users@...r.kernel.org, Dapeng Mi <dapeng1.mi@...el.com>
Subject: Re: [Patch v4 09/13] perf/x86/intel: Setup PEBS data configuration
 and enable legacy groups

On Fri, Jun 20, 2025 at 10:39:05AM +0000, Dapeng Mi wrote:
> +static inline void __intel_update_large_pebs_flags(struct pmu *pmu)
> +{
> +	u64 caps = hybrid(pmu, arch_pebs_cap).caps;
> +
> +	x86_pmu.large_pebs_flags |= PERF_SAMPLE_TIME;
> +	if (caps & ARCH_PEBS_LBR)
> +		x86_pmu.large_pebs_flags |= PERF_SAMPLE_BRANCH_STACK;
> +
> +	if (!(caps & ARCH_PEBS_AUX))
> +		x86_pmu.large_pebs_flags &= ~PERF_SAMPLE_DATA_SRC;

> +	if (!(caps & ARCH_PEBS_GPR))
> +		x86_pmu.large_pebs_flags &=
> +			~(PERF_SAMPLE_REGS_INTR | PERF_SAMPLE_REGS_USER);

Coding style wants { } on this, because multi-line.

> +}