linux-kernel - Re: [PATCH] arm64: dts: qcom: sa8775p: rename bus clock to follow the bindings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <13471ca7-0e3c-444a-947b-51bce87396cb@oss.qualcomm.com>
Date: Sat, 21 Jun 2025 13:05:33 +0200
From: Konrad Dybcio <konrad.dybcio@....qualcomm.com>
To: Dmitry Baryshkov <dmitry.baryshkov@....qualcomm.com>
Cc: Bjorn Andersson <andersson@...nel.org>,
        Konrad Dybcio <konradybcio@...nel.org>, Rob Herring <robh@...nel.org>,
        Krzysztof Kozlowski <krzk+dt@...nel.org>,
        Conor Dooley
 <conor+dt@...nel.org>,
        Dmitry Baryshkov <lumag@...nel.org>,
        Mahadevan <quic_mahap@...cinc.com>, linux-arm-msm@...r.kernel.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] arm64: dts: qcom: sa8775p: rename bus clock to follow the
 bindings

On 6/15/25 2:34 PM, Dmitry Baryshkov wrote:
> On Sat, Jun 14, 2025 at 10:10:59PM +0200, Konrad Dybcio wrote:
>> On 6/2/25 9:23 AM, Dmitry Baryshkov wrote:
>>> DT bindings for the DPU SA8775P declare the first clock to be "nrt_bus",
>>> not just "bus". Fix the DT file accordingly.
>>>
>>> Fixes: 2f39d2d46c73 ("arm64: dts: qcom: sa8775p: add display dt nodes for MDSS0 and DPU")
>>> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@....qualcomm.com>
>>> ---
>>>  arch/arm64/boot/dts/qcom/sa8775p.dtsi | 2 +-
>>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/arch/arm64/boot/dts/qcom/sa8775p.dtsi b/arch/arm64/boot/dts/qcom/sa8775p.dtsi
>>> index 45f536633f6449e6ce6bb0109b5446968921f684..7eac6919b2992a3512df1e042af22d0cbad04853 100644
>>> --- a/arch/arm64/boot/dts/qcom/sa8775p.dtsi
>>> +++ b/arch/arm64/boot/dts/qcom/sa8775p.dtsi
>>> @@ -4122,7 +4122,7 @@ mdss0_mdp: display-controller@...1000 {
>>>  					 <&dispcc0 MDSS_DISP_CC_MDSS_MDP_LUT_CLK>,
>>>  					 <&dispcc0 MDSS_DISP_CC_MDSS_MDP_CLK>,
>>>  					 <&dispcc0 MDSS_DISP_CC_MDSS_VSYNC_CLK>;
>>> -				clock-names = "bus",
>>> +				clock-names = "nrt_bus",
>>
>> Is it the "nrt" clock though, and not "rt"?
>>
>> There used to be a split for non-/real-time use cases, but
>> I have little idea about the specifics.
> 
> I think this matches the SM8550 / SM8650. SM8550 provides a good
> example, because it lists both "bus" and "nrt_bus" clocks:
> 
>                                 clocks = <&gcc GCC_DISP_AHB_CLK>,
>                                          <&gcc GCC_DISP_HF_AXI_CLK>,
> 					 [...]
>                                 clock-names = "bus",
>                                               "nrt_bus",
> 
> So, I think, let's fix the clock name here to follow the the schema and
> other pltforms.

if we don't know any better, let's just make the checker happy

Reviewed-by: Konrad Dybcio <konrad.dybcio@....qualcomm.com>

Konrad