linux-kernel - Re: [PATCH net-next] ethtool: pse-pd: Add missing linux/export.h include

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250621070043.21e1c852@kernel.org>
Date: Sat, 21 Jun 2025 07:00:43 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Simon Horman <horms@...nel.org>
Cc: Kory Maincent <kory.maincent@...tlin.com>, netdev@...r.kernel.org,
 linux-kernel@...r.kernel.org, kernel test robot <lkp@...el.com>,
 thomas.petazzoni@...tlin.com, Oleksij Rempel <o.rempel@...gutronix.de>,
 Andrew Lunn <andrew@...n.ch>, "David S. Miller" <davem@...emloft.net>, Eric
 Dumazet <edumazet@...gle.com>, Paolo Abeni <pabeni@...hat.com>
Subject: Re: [PATCH net-next] ethtool: pse-pd: Add missing linux/export.h
 include

On Fri, 20 Jun 2025 11:14:52 +0100 Simon Horman wrote:
> On Thu, Jun 19, 2025 at 06:25:47PM +0200, Kory Maincent wrote:
> > Fix missing linux/export.h header include in net/ethtool/pse-pd.c to resolve
> > build warning reported by the kernel test robot.
> > 
> > Reported-by: kernel test robot <lkp@...el.com>
> > Closes: https://lore.kernel.org/oe-kbuild-all/202506200024.T3O0FWeR-lkp@intel.com/
> > Signed-off-by: Kory Maincent <kory.maincent@...tlin.com>  
> 
> The change that introduced this warning introduced a log of such warnings.
> Including a lot in the Networking subsystem. (I did not count them.)
> 
> So I agree with the point from Sean Christopherson [*] is that if the patch
> that introduced the warnings isn't reverted

It was reverted, thankfully. So I assume we treat this patch as 
a normal "include what you need" case and therefore apply.. ?

> then a more comprehensive approach is needed to address these warnings.
> 
> [*] Re: [PATCH 3/6] KVM: x86: hyper-v: Fix warnings for missing export.h header inclusion
>     https://lore.kernel.org/netdev/aEl9kO81-kp0hhw0@google.com/