linux-kernel - Re: [PATCH] can: m_can: apply rate-limiting to lost msg in rx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <d855c26a-1982-4fc6-9333-93df4a5a98d9@wanadoo.fr>
Date: Sat, 21 Jun 2025 11:13:33 +0900
From: Vincent Mailhol <mailhol.vincent@...adoo.fr>
To: Sean Nyekjaer <sean@...nix.com>
Cc: linux-can@...r.kernel.org, linux-kernel@...r.kernel.org,
 Chandrasekar Ramakrishnan <rcsekar@...sung.com>,
 Marc Kleine-Budde <mkl@...gutronix.de>, Fengguang Wu
 <fengguang.wu@...el.com>, Varka Bhadram <varkabhadram@...il.com>,
 Dong Aisheng <b29396@...escale.com>
Subject: Re: [PATCH] can: m_can: apply rate-limiting to lost msg in rx

On 20/06/2025 at 19:00, Sean Nyekjaer wrote:
> Wrap the "msg lost in rxf0" error in m_can_handle_lost_msg() with
> a call to net_ratelimit() to prevent flooding the kernel log
> with repeated error messages.

Note that another solution is to simply remove the error message. The users can
use the CAN error frames or the netstasts instead to see if lost messages occurred.

That said, I am OK with your proposed patch. See above comment as a simple FYI.

> Fixes: e0d1f4816f2a ("can: m_can: add Bosch M_CAN controller support")
> Signed-off-by: Sean Nyekjaer <sean@...nix.com>

Reviewed-by: Vincent Mailhol <mailhol.vincent@...adoo.fr>


Yours sincerely,
Vincent Mailhol