linux-kernel - Re: [PATCH v7 07/10] power: reset: macsmc-reboot: Add driver for rebooting via Apple SMC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d6b778ee-02c0-4dd2-b33f-cec16c17807c@kernel.org>
Date: Sat, 21 Jun 2025 17:47:02 +0200
From: Sven Peter <sven@...nel.org>
To: Nick Chan <towinchenmi@...il.com>, Lee Jones <lee@...nel.org>
Cc: asahi@...ts.linux.dev, Neal Gompa <neal@...pa.dev>,
 linux-arm-kernel@...ts.infradead.org, linux-gpio@...r.kernel.org,
 devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
 linux-pm@...r.kernel.org, Linus Walleij <linus.walleij@...aro.org>,
 "Russell King (Oracle)" <rmk+kernel@...linux.org.uk>,
 Hector Martin <marcan@...can.st>, Conor Dooley <conor+dt@...nel.org>,
 Janne Grunau <j@...nau.net>,
 Sebastian Reichel <sebastian.reichel@...labora.com>,
 Sebastian Reichel <sre@...nel.org>, Alyssa Rosenzweig
 <alyssa@...enzweig.io>, Bartosz Golaszewski <brgl@...ev.pl>,
 Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
 Marc Zyngier <maz@...nel.org>
Subject: Re: [PATCH v7 07/10] power: reset: macsmc-reboot: Add driver for
 rebooting via Apple SMC

On 16.06.25 06:13, Nick Chan wrote:
> 
> 
> On 10/6/2025 23:29, Sven Peter wrote:
>> From: Hector Martin <marcan@...can.st>
>>
>> This driver implements the reboot/shutdown support exposed by the SMC
>> on Apple Silicon machines, such as Apple M1 Macs.
>>
>> Signed-off-by: Hector Martin <marcan@...can.st>
>> Reviewed-by: Alyssa Rosenzweig <alyssa@...enzweig.io>
>> Reviewed-by: Neal Gompa <neal@...pa.dev>
>> Reviewed-by: Sebastian Reichel <sebastian.reichel@...labora.com>
>> Signed-off-by: Sven Peter <sven@...nel.org>
>> ---
>>   MAINTAINERS                         |   1 +
>>   drivers/power/reset/Kconfig         |   9 ++
>>   drivers/power/reset/Makefile        |   1 +
>>   drivers/power/reset/macsmc-reboot.c | 290 ++++++++++++++++++++++++++++++++++++
>>   4 files changed, 301 insertions(+)
> [...]
> 
> It seems that the reboot driver still probes even without the smc_reboot node in the smc node:


That's odd...

Lee, is it expected that a mfd sub-device declared with
MFD_CELL_OF("macsmc-reboot", NULL, NULL, 0, 0, "apple,smc-reboot"),
is loaded even if there's no corresponding node in the device tree?

I'll have to re-add the check that makes sure the sub-device is 
available then.


Thanks,


Sven