linux-kernel - Re: [PATCH bpf-next 1/4] kernfs: Add __kernfs_xattr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aFYbCVRZyyoOXYa-@slm.duckdns.org>
Date: Fri, 20 Jun 2025 16:38:01 -1000
From: Tejun Heo <tj@...nel.org>
To: Christian Brauner <brauner@...nel.org>
Cc: Song Liu <song@...nel.org>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	bpf@...r.kernel.org, linux-fsdevel@...r.kernel.org,
	linux-kernel@...r.kernel.org, linux-security-module@...r.kernel.org,
	kernel-team@...a.com, andrii@...nel.org, eddyz87@...il.com,
	ast@...nel.org, daniel@...earbox.net, martin.lau@...ux.dev,
	viro@...iv.linux.org.uk, jack@...e.cz, kpsingh@...nel.org,
	mattbobrowski@...gle.com, amir73il@...il.com,
	daan.j.demeyer@...il.com
Subject: Re: [PATCH bpf-next 1/4] kernfs: Add __kernfs_xattr_get for RCU
 protected access

On Thu, Jun 19, 2025 at 12:01:19PM +0200, Christian Brauner wrote:
> From bdc53435a1cd5c456dc28d8239eff0e7fa4e8dda Mon Sep 17 00:00:00 2001
> From: Christian Brauner <brauner@...nel.org>
> Date: Thu, 19 Jun 2025 11:50:26 +0200
> Subject: [PATCH] kernfs: remove iattr_mutex
> 
> All allocations of struct kernfs_iattrs are serialized through a global
> mutex. Simply do a racy allocation and let the first one win. I bet most
> callers are under inode->i_rwsem anyway and it wouldn't be needed but
> let's not require that.
> 
> Signed-off-by: Christian Brauner <brauner@...nel.org>

Acked-by: Tejun Heo <tj@...nel.org>

Thanks.

-- 
tejun