linux-kernel - Re: [PATCH v5 01/11] dt-bindings: iio: adc: Add AD4170

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250621173735.176184d0@jic23-huawei>
Date: Sat, 21 Jun 2025 17:37:35 +0100
From: Jonathan Cameron <jic23@...nel.org>
To: Conor Dooley <conor@...nel.org>
Cc: Marcelo Schmitt <marcelo.schmitt@...log.com>, linux-iio@...r.kernel.org,
 devicetree@...r.kernel.org, linux-gpio@...r.kernel.org,
 linux-kernel@...r.kernel.org, lars@...afoo.de,
 Michael.Hennerich@...log.com, dlechner@...libre.com, nuno.sa@...log.com,
 andy@...nel.org, robh@...nel.org, krzk+dt@...nel.org, conor+dt@...nel.org,
 linus.walleij@...aro.org, brgl@...ev.pl, marcelo.schmitt1@...il.com
Subject: Re: [PATCH v5 01/11] dt-bindings: iio: adc: Add AD4170

> 
> Otherwise, what you have here looks sane enough to me - but I'd like to
> see some comments from Jonathan or David etc about your approach to the
> excitation properties.

They look sane to me.  The complexity of devices that handle weigh cells and
similar are always a pain.  In theory we could have a go at describing
the weigh-cell in DT and then try to derive the 'right' settings but that
seems like a very complex thing to do.  Long time since I did anything with
weigh cells, but I think you mostly read the settings to use of a datasheet rather
than deriving them from first principles. Thermocouples are similar (I'm not
that familiar with RTDs)

As to the handling of the different sensor types - that seems like a sensible
way to constrain the binding and end up with sane readable combinations rather
than a bunch of excitation settings with no info on what is connected.

Not sure this is the perfect solution, but to me it looks good enough and
flexible / general enough to cover a wide range of other devices.

Jonathan

> 
> Cheers,
> Conor.