linux-kernel - Re: [PATCH v9 07/11] iio: accel: adxl345: add activity event feature

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aFcOPky_EsatfsJu@surfacebook.localdomain>
Date: Sat, 21 Jun 2025 22:55:42 +0300
From: Andy Shevchenko <andy.shevchenko@...il.com>
To: Lothar Rubusch <l.rubusch@...il.com>
Cc: Andy Shevchenko <andriy.shevchenko@...el.com>, lars@...afoo.de,
	Michael.Hennerich@...log.com, jic23@...nel.org,
	dlechner@...libre.com, nuno.sa@...log.com, andy@...nel.org,
	corbet@....net, linux-iio@...r.kernel.org,
	linux-kernel@...r.kernel.org, linux-doc@...r.kernel.org,
	eraretuya@...il.com
Subject: Re: [PATCH v9 07/11] iio: accel: adxl345: add activity event feature

Sat, Jun 21, 2025 at 08:06:49PM +0200, Lothar Rubusch kirjoitti:

[...]

> > > +     ret = regmap_read(st->regmap, ADXL345_REG_ACT_INACT_CTRL, &axis_ctrl);
> > > +     if (ret)
> > > +             return ret;
> > > +
> > > +     switch (type) {
> > > +     case ADXL345_ACTIVITY:
> > > +             en = FIELD_GET(ADXL345_ACT_X_EN, axis_ctrl) |
> > > +                     FIELD_GET(ADXL345_ACT_Y_EN, axis_ctrl) |
> > > +                     FIELD_GET(ADXL345_ACT_Z_EN, axis_ctrl);
> >
> > Something happened to the indentation.
> > Ditto for several places in the code (upper and lower from this).
> 
> What is the matter with the indention here? I'm doing `checkpatch.pl
> --strict --codespell` on that and don't get an issue? Would you expect
> cases like the FIELD_GET() calls on the next line, linked by a binary
> OR, to be indented by yet another TAB?

All 'F':s should be on the same column (since the email already mangled
[not by me], here is just an example).

             en = FIELD_GET(ADXL345_ACT_X_EN, axis_ctrl) |
                  FIELD_GET(ADXL345_ACT_Y_EN, axis_ctrl) |
                  FIELD_GET(ADXL345_ACT_Z_EN, axis_ctrl);

> > > +             break;
> > > +     default:
> > > +             return -EINVAL;
> > > +     }
> > > +
> > > +     if (!en)
> > > +             return en;
> > > +
> > > +     /* Check if corresponding interrupts are enabled */
> > > +     ret = regmap_read(st->regmap, ADXL345_REG_INT_ENABLE, &regval);
> > > +     if (ret)
> > > +             return ret;
> > > +
> > > +     return adxl345_act_int_reg[type] & regval;
> > > +}

...

Really, cut the unrelated context in the replies!

-- 
With Best Regards,
Andy Shevchenko