linux-kernel - Re: [PATCH] iio: adc: ad7380: fix adi,gain-milli property parsing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250622152506.238c1322@jic23-huawei>
Date: Sun, 22 Jun 2025 15:25:06 +0100
From: Jonathan Cameron <jic23@...nel.org>
To: David Lechner <dlechner@...libre.com>
Cc: Michael Hennerich <michael.hennerich@...log.com>, Nuno Sá
 <nuno.sa@...log.com>, Lars-Peter Clausen <lars@...afoo.de>, Julien Stephan
 <jstephan@...libre.com>, Jonathan Cameron <Jonathan.Cameron@...wei.com>,
 linux-iio@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] iio: adc: ad7380: fix adi,gain-milli property parsing

On Thu, 19 Jun 2025 10:24:22 -0500
David Lechner <dlechner@...libre.com> wrote:

> Change the data type of the "adi,gain-milli" property from u32 to u16.
> The devicetree binding specifies it as uint16, so we need to read it as
> such to avoid an -EOVERFLOW error when parsing the property.
> 
> Fixes: c904e6dcf402 ("iio: adc: ad7380: add support for adaq4370-4 and adaq4380-4")
> Signed-off-by: David Lechner <dlechner@...libre.com>
Applied to the fixes-togreg branch of iio.git and marked for stable.

Thanks,

J
> ---
>  drivers/iio/adc/ad7380.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/iio/adc/ad7380.c b/drivers/iio/adc/ad7380.c
> index aef85093eb16cbe9cc062f8cb4239e955c8a21b6..fd17e28e279191c2603537a9bddc7eb9976c144c 100644
> --- a/drivers/iio/adc/ad7380.c
> +++ b/drivers/iio/adc/ad7380.c
> @@ -1920,8 +1920,9 @@ static int ad7380_probe(struct spi_device *spi)
>  
>  	if (st->chip_info->has_hardware_gain) {
>  		device_for_each_child_node_scoped(dev, node) {
> -			unsigned int channel, gain;
> +			unsigned int channel;
>  			int gain_idx;
> +			u16 gain;
>  
>  			ret = fwnode_property_read_u32(node, "reg", &channel);
>  			if (ret)
> @@ -1933,7 +1934,7 @@ static int ad7380_probe(struct spi_device *spi)
>  						     "Invalid channel number %i\n",
>  						     channel);
>  
> -			ret = fwnode_property_read_u32(node, "adi,gain-milli",
> +			ret = fwnode_property_read_u16(node, "adi,gain-milli",
>  						       &gain);
>  			if (ret && ret != -EINVAL)
>  				return dev_err_probe(dev, ret,
> 
> ---
> base-commit: a3245ebdfac846ce0b563a3ed474be2e15381f9f
> change-id: 20250619-iio-adc-ad7380-fix-adi-gain-milli-parsing-8df01280f493
> 
> Best regards,