linux-kernel - Re: [PATCH v1 0/2] Add BMP390 IIO driver, device tree bindings and support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250622160637.554b1953@jic23-huawei>
Date: Sun, 22 Jun 2025 16:06:37 +0100
From: Jonathan Cameron <jic23@...nel.org>
To: <liquancin.mereenamathai@...bosch.com>
Cc: <linux-iio@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
 <dlechner@...libre.com>, <nuno.sa@...log.com>, <andy@...nel.org>,
 <vassilisamir@...il.com>, <marcelo.schmitt1@...il.com>,
 <javier.carrasco.cruz@...il.com>, <Xu.Zhang@...bosch.com>,
 <Maoting.Bian@...bosch.com>
Subject: Re: [PATCH v1 0/2] Add BMP390 IIO driver, device tree bindings and
 support

On Fri, 20 Jun 2025 10:24:53 +0530
<liquancin.mereenamathai@...bosch.com> wrote:

> From: Liquancin Mereena Mathai <liquancin.mereenamathai@...bosch.com>
> 
> This patch series adds support for the Bosch BMP390 pressure sensor to the
> Linux IIO subsystem. It includes the main driver implementation as well as
> the necessary device tree bindings for integration on supported platforms.

Hi Liquancin, 

Great to see this driver.  However, it is huge which will make it very challenging
to review.  I'll take a first look but in general you need to break this up
into more manageable steps of building up driver complexity.  The driver
must work and be useful at each step, but the usual approach is to introduce
first a fairly minimal driver that does basic measurements only and then build
up from there.  If any patch is getting substantially over 1000 lines of code
then it becomes unmanageable without reviewers dedicating a significant chunk
of their day to that review and hence them finding that time can take a while
if it happens at all.

Only exception to this is that the dt binding should be as complete
as possible from the start.

Jonathan

> 
> Patch 1 adds the IIO driver for the BMP390 pressure sensor.
> Patch 2 introduces the device tree bindings documentation.
> 
> Liquancin Mereena Mathai (2):
>   Add the iio driver for bosch pressure sensor bmp390. The bmp390 is a
>     pressure sensor module. It will support SPI and I2C protocol based
>     on configuration.
>   dt-bindings: iio driver: Add BMP390 pressure sensor device tree
>     binding
> 
>  .../bindings/iio/pressure/bosch,bmp390.yaml   |   65 +
>  MAINTAINERS                                   |    7 +
>  drivers/iio/pressure/Kconfig                  |   26 +
>  drivers/iio/pressure/Makefile                 |    1 +
>  drivers/iio/pressure/bmp390/Kconfig           |   29 +
>  drivers/iio/pressure/bmp390/Makefile          |   32 +
>  drivers/iio/pressure/bmp390/bmp3.c            | 2781 +++++++++++++++++
>  drivers/iio/pressure/bmp390/bmp3.h            |  537 ++++
>  drivers/iio/pressure/bmp390/bmp390_driver.c   | 1604 ++++++++++
>  drivers/iio/pressure/bmp390/bmp390_driver.h   |  232 ++
>  drivers/iio/pressure/bmp390/bmp390_i2c.c      |  328 ++
>  .../iio/pressure/bmp390/bmp390_iio_buffer.c   |  220 ++
>  drivers/iio/pressure/bmp390/bmp390_spi.c      |  286 ++
>  drivers/iio/pressure/bmp390/bmp3_defs.h       |  871 ++++++
>  drivers/iio/pressure/bmp390/bmp3_selftest.c   |  184 ++
>  drivers/iio/pressure/bmp390/bmp3_selftest.h   |   93 +
>  16 files changed, 7296 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/iio/pressure/bosch,bmp390.yaml
>  create mode 100644 drivers/iio/pressure/bmp390/Kconfig
>  create mode 100644 drivers/iio/pressure/bmp390/Makefile
>  create mode 100644 drivers/iio/pressure/bmp390/bmp3.c
>  create mode 100644 drivers/iio/pressure/bmp390/bmp3.h
>  create mode 100644 drivers/iio/pressure/bmp390/bmp390_driver.c
>  create mode 100644 drivers/iio/pressure/bmp390/bmp390_driver.h
>  create mode 100644 drivers/iio/pressure/bmp390/bmp390_i2c.c
>  create mode 100644 drivers/iio/pressure/bmp390/bmp390_iio_buffer.c
>  create mode 100644 drivers/iio/pressure/bmp390/bmp390_spi.c
>  create mode 100644 drivers/iio/pressure/bmp390/bmp3_defs.h
>  create mode 100644 drivers/iio/pressure/bmp390/bmp3_selftest.c
>  create mode 100644 drivers/iio/pressure/bmp390/bmp3_selftest.h
>