| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <202506221133.9JH31DNw-lkp@intel.com>
Date: Sun, 22 Jun 2025 11:58:30 +0800
From: kernel test robot <lkp@...el.com>
To: Rouven Czerwinski <rouven@...rwinskis.de>,
Arend van Spriel <arend.vanspriel@...adcom.com>
Cc: oe-kbuild-all@...ts.linux.dev, kernel@...gutronix.de,
Rouven Czerwinski <rouven@...rwinskis.de>,
linux-wireless@...r.kernel.org, brcm80211@...ts.linux.dev,
brcm80211-dev-list.pdl@...adcom.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] brcmfmac: remove always true variable and code
Hi Rouven,
kernel test robot noticed the following build warnings:
[auto build test WARNING on wireless-next/main]
[also build test WARNING on wireless/main linus/master v6.16-rc2 next-20250620]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Rouven-Czerwinski/brcmfmac-remove-always-true-variable-and-code/20250621-193706
base: https://git.kernel.org/pub/scm/linux/kernel/git/wireless/wireless-next.git main
patch link: https://lore.kernel.org/r/20250621112912.180436-2-rouven%40czerwinskis.de
patch subject: [PATCH 2/2] brcmfmac: remove always true variable and code
config: arc-allyesconfig (https://download.01.org/0day-ci/archive/20250622/202506221133.9JH31DNw-lkp@intel.com/config)
compiler: arc-linux-gcc (GCC) 15.1.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250622/202506221133.9JH31DNw-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202506221133.9JH31DNw-lkp@intel.com/
All warnings (new ones prefixed by >>):
drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c: In function 'brcmf_sdio_sendfromq':
>> drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c:2329:13: warning: variable 'ret' set but not used [-Wunused-but-set-variable]
2329 | int ret = 0, prec_out, i;
| ^~~
vim +/ret +2329 drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c
5b435de0d78686 drivers/net/wireless/brcm80211/brcmfmac/dhd_sdio.c Arend van Spriel 2011-10-05 2324
82d7f3c10cf41c drivers/net/wireless/brcm80211/brcmfmac/dhd_sdio.c Arend van Spriel 2013-12-12 2325 static uint brcmf_sdio_sendfromq(struct brcmf_sdio *bus, uint maxframes)
5b435de0d78686 drivers/net/wireless/brcm80211/brcmfmac/dhd_sdio.c Arend van Spriel 2011-10-05 2326 {
5b435de0d78686 drivers/net/wireless/brcm80211/brcmfmac/dhd_sdio.c Arend van Spriel 2011-10-05 2327 struct sk_buff *pkt;
8da9d2c8688825 drivers/net/wireless/brcm80211/brcmfmac/dhd_sdio.c Franky Lin 2013-11-29 2328 struct sk_buff_head pktq;
8da9d2c8688825 drivers/net/wireless/brcm80211/brcmfmac/dhd_sdio.c Franky Lin 2013-11-29 @2329 int ret = 0, prec_out, i;
5b435de0d78686 drivers/net/wireless/brcm80211/brcmfmac/dhd_sdio.c Arend van Spriel 2011-10-05 2330 uint cnt = 0;
8da9d2c8688825 drivers/net/wireless/brcm80211/brcmfmac/dhd_sdio.c Franky Lin 2013-11-29 2331 u8 tx_prec_map, pkt_num;
5b435de0d78686 drivers/net/wireless/brcm80211/brcmfmac/dhd_sdio.c Arend van Spriel 2011-10-05 2332
5b435de0d78686 drivers/net/wireless/brcm80211/brcmfmac/dhd_sdio.c Arend van Spriel 2011-10-05 2333 brcmf_dbg(TRACE, "Enter\n");
5b435de0d78686 drivers/net/wireless/brcm80211/brcmfmac/dhd_sdio.c Arend van Spriel 2011-10-05 2334
5b435de0d78686 drivers/net/wireless/brcm80211/brcmfmac/dhd_sdio.c Arend van Spriel 2011-10-05 2335 tx_prec_map = ~bus->flowcontrol;
5b435de0d78686 drivers/net/wireless/brcm80211/brcmfmac/dhd_sdio.c Arend van Spriel 2011-10-05 2336
5b435de0d78686 drivers/net/wireless/brcm80211/brcmfmac/dhd_sdio.c Arend van Spriel 2011-10-05 2337 /* Send frames until the limit or some other event */
8da9d2c8688825 drivers/net/wireless/brcm80211/brcmfmac/dhd_sdio.c Franky Lin 2013-11-29 2338 for (cnt = 0; (cnt < maxframes) && data_ok(bus);) {
8da9d2c8688825 drivers/net/wireless/brcm80211/brcmfmac/dhd_sdio.c Franky Lin 2013-11-29 2339 pkt_num = 1;
8da9d2c8688825 drivers/net/wireless/brcm80211/brcmfmac/dhd_sdio.c Franky Lin 2013-11-29 2340 if (bus->txglom)
8da9d2c8688825 drivers/net/wireless/brcm80211/brcmfmac/dhd_sdio.c Franky Lin 2013-11-29 2341 pkt_num = min_t(u8, bus->tx_max - bus->tx_seq,
af1fa210f4fc6e drivers/net/wireless/brcm80211/brcmfmac/dhd_sdio.c Arend van Spriel 2014-02-27 2342 bus->sdiodev->txglomsz);
8da9d2c8688825 drivers/net/wireless/brcm80211/brcmfmac/dhd_sdio.c Franky Lin 2013-11-29 2343 pkt_num = min_t(u32, pkt_num,
8da9d2c8688825 drivers/net/wireless/brcm80211/brcmfmac/dhd_sdio.c Franky Lin 2013-11-29 2344 brcmu_pktq_mlen(&bus->txq, ~bus->flowcontrol));
fed7ec44e7ef64 drivers/net/wireless/brcm80211/brcmfmac/dhd_sdio.c Hante Meuleman 2014-03-15 2345 __skb_queue_head_init(&pktq);
fed7ec44e7ef64 drivers/net/wireless/brcm80211/brcmfmac/dhd_sdio.c Hante Meuleman 2014-03-15 2346 spin_lock_bh(&bus->txq_lock);
8da9d2c8688825 drivers/net/wireless/brcm80211/brcmfmac/dhd_sdio.c Franky Lin 2013-11-29 2347 for (i = 0; i < pkt_num; i++) {
8da9d2c8688825 drivers/net/wireless/brcm80211/brcmfmac/dhd_sdio.c Franky Lin 2013-11-29 2348 pkt = brcmu_pktq_mdeq(&bus->txq, tx_prec_map,
8da9d2c8688825 drivers/net/wireless/brcm80211/brcmfmac/dhd_sdio.c Franky Lin 2013-11-29 2349 &prec_out);
8da9d2c8688825 drivers/net/wireless/brcm80211/brcmfmac/dhd_sdio.c Franky Lin 2013-11-29 2350 if (pkt == NULL)
5b435de0d78686 drivers/net/wireless/brcm80211/brcmfmac/dhd_sdio.c Arend van Spriel 2011-10-05 2351 break;
8da9d2c8688825 drivers/net/wireless/brcm80211/brcmfmac/dhd_sdio.c Franky Lin 2013-11-29 2352 __skb_queue_tail(&pktq, pkt);
5b435de0d78686 drivers/net/wireless/brcm80211/brcmfmac/dhd_sdio.c Arend van Spriel 2011-10-05 2353 }
fed7ec44e7ef64 drivers/net/wireless/brcm80211/brcmfmac/dhd_sdio.c Hante Meuleman 2014-03-15 2354 spin_unlock_bh(&bus->txq_lock);
4dd8b26a40acf8 drivers/net/wireless/brcm80211/brcmfmac/sdio.c Hante Meuleman 2015-01-25 2355 if (i == 0)
8da9d2c8688825 drivers/net/wireless/brcm80211/brcmfmac/dhd_sdio.c Franky Lin 2013-11-29 2356 break;
5b435de0d78686 drivers/net/wireless/brcm80211/brcmfmac/dhd_sdio.c Arend van Spriel 2011-10-05 2357
82d7f3c10cf41c drivers/net/wireless/brcm80211/brcmfmac/dhd_sdio.c Arend van Spriel 2013-12-12 2358 ret = brcmf_sdio_txpkt(bus, &pktq, SDPCM_DATA_CHANNEL);
fed7ec44e7ef64 drivers/net/wireless/brcm80211/brcmfmac/dhd_sdio.c Hante Meuleman 2014-03-15 2359
8da9d2c8688825 drivers/net/wireless/brcm80211/brcmfmac/dhd_sdio.c Franky Lin 2013-11-29 2360 cnt += i;
5b435de0d78686 drivers/net/wireless/brcm80211/brcmfmac/dhd_sdio.c Arend van Spriel 2011-10-05 2361 }
5b435de0d78686 drivers/net/wireless/brcm80211/brcmfmac/dhd_sdio.c Arend van Spriel 2011-10-05 2362
5b435de0d78686 drivers/net/wireless/brcm80211/brcmfmac/dhd_sdio.c Arend van Spriel 2011-10-05 2363 /* Deflow-control stack if needed */
a1ce7a0d6a4f1e drivers/net/wireless/brcm80211/brcmfmac/sdio.c Arend van Spriel 2015-02-06 2364 if ((bus->sdiodev->state == BRCMF_SDIOD_DATA) &&
c8bf34849f92c5 drivers/net/wireless/brcm80211/brcmfmac/dhd_sdio.c Franky Lin 2011-12-16 2365 bus->txoff && (pktq_len(&bus->txq) < TXLOW)) {
90d03ff71b52ba drivers/net/wireless/brcm80211/brcmfmac/dhd_sdio.c Hante Meuleman 2012-09-11 2366 bus->txoff = false;
20ec4f57498f87 drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c Franky Lin 2017-03-10 2367 brcmf_proto_bcdc_txflowblock(bus->sdiodev->dev, false);
c8bf34849f92c5 drivers/net/wireless/brcm80211/brcmfmac/dhd_sdio.c Franky Lin 2011-12-16 2368 }
5b435de0d78686 drivers/net/wireless/brcm80211/brcmfmac/dhd_sdio.c Arend van Spriel 2011-10-05 2369
5b435de0d78686 drivers/net/wireless/brcm80211/brcmfmac/dhd_sdio.c Arend van Spriel 2011-10-05 2370 return cnt;
5b435de0d78686 drivers/net/wireless/brcm80211/brcmfmac/dhd_sdio.c Arend van Spriel 2011-10-05 2371 }
5b435de0d78686 drivers/net/wireless/brcm80211/brcmfmac/dhd_sdio.c Arend van Spriel 2011-10-05 2372
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
Powered by blists - more mailing lists