linux-kernel - Re: [PATCH v3 3/6] platform/x86: firmware_attributes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <DASS1Q8GNS4V.1Z08IM0OKRY3Z@gmail.com>
Date: Sun, 22 Jun 2025 01:28:59 -0300
From: "Kurt Borja" <kuurtb@...il.com>
To: "Kurt Borja" <kuurtb@...il.com>, "Hans de Goede" <hdegoede@...hat.com>,
 Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>,
 Thomas Weißschuh <linux@...ssschuh.net>, "Joshua Grisham"
 <josh@...huagrisham.com>, "Mark Pearson" <mpearson-lenovo@...ebb.ca>,
 "Armin Wolf" <W_Armin@....de>, "Mario Limonciello"
 <mario.limonciello@....com>
Cc: "Antheas Kapenekakis" <lkml@...heas.dev>, "Derek J. Clark"
 <derekjohn.clark@...il.com>, "Prasanth Ksr" <prasanth.ksr@...l.com>, "Jorge
 Lopez" <jorge.lopez2@...com>, <platform-driver-x86@...r.kernel.org>,
 <linux-kernel@...r.kernel.org>, <Dell.Client.Kernel@...l.com>
Subject: Re: [PATCH v3 3/6] platform/x86: firmware_attributes_class: Move
 header to include directory

On Sat Jun 21, 2025 at 9:04 PM -03, Kurt Borja wrote:
> Move firmware_attributes_class.h to include/linux/ to avoid hardcoding
> paths inside drivers/platform/x86/.
>
> Signed-off-by: Kurt Borja <kuurtb@...il.com>

I forgot to add:

Suggested-by: Joshua Grisham <josh@...huagrisham.com>

> ---
>  drivers/platform/x86/dell/dell-wmi-sysman/sysman.c                  | 2 +-
>  drivers/platform/x86/firmware_attributes_class.c                    | 2 +-
>  drivers/platform/x86/hp/hp-bioscfg/bioscfg.c                        | 2 +-
>  drivers/platform/x86/lenovo/think-lmi.c                             | 2 +-
>  drivers/platform/x86/samsung-galaxybook.c                           | 2 +-
>  {drivers/platform/x86 => include/linux}/firmware_attributes_class.h | 0
>  6 files changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/platform/x86/dell/dell-wmi-sysman/sysman.c b/drivers/platform/x86/dell/dell-wmi-sysman/sysman.c
> index d00389b860e4ea0655c740c78bc3751f323b6370..3aec09987ab145508ed05b02e61a6d94edf79484 100644
> --- a/drivers/platform/x86/dell/dell-wmi-sysman/sysman.c
> +++ b/drivers/platform/x86/dell/dell-wmi-sysman/sysman.c
> @@ -12,8 +12,8 @@
>  #include <linux/module.h>
>  #include <linux/kernel.h>
>  #include <linux/wmi.h>
> +#include <linux/firmware_attributes_class.h>
>  #include "dell-wmi-sysman.h"
> -#include "../../firmware_attributes_class.h"
>  
>  #define MAX_TYPES  4
>  #include <linux/nls.h>
> diff --git a/drivers/platform/x86/firmware_attributes_class.c b/drivers/platform/x86/firmware_attributes_class.c
> index 034f9254240b048f58c97c18062db03f771f8139..af39ed9ad2836147c98b4bb0b89e70e96ee34b71 100644
> --- a/drivers/platform/x86/firmware_attributes_class.c
> +++ b/drivers/platform/x86/firmware_attributes_class.c
> @@ -10,7 +10,7 @@
>  #include <linux/slab.h>
>  #include <linux/types.h>
>  #include <linux/string_choices.h>
> -#include "firmware_attributes_class.h"
> +#include <linux/firmware_attributes_class.h>
>  
>  #define to_fwat_bool_data(_c) \
>  	container_of_const(_c, struct fwat_bool_data, group)
> diff --git a/drivers/platform/x86/hp/hp-bioscfg/bioscfg.c b/drivers/platform/x86/hp/hp-bioscfg/bioscfg.c
> index 13237890fc92002e7e730b1c235ddf068a6737cd..2df31af8a3b4ac88710af1fae2d5dabbb3185f1d 100644
> --- a/drivers/platform/x86/hp/hp-bioscfg/bioscfg.c
> +++ b/drivers/platform/x86/hp/hp-bioscfg/bioscfg.c
> @@ -12,7 +12,7 @@
>  #include <linux/kernel.h>
>  #include <linux/wmi.h>
>  #include "bioscfg.h"
> -#include "../../firmware_attributes_class.h"
> +#include <linux/firmware_attributes_class.h>
>  #include <linux/nls.h>
>  #include <linux/errno.h>
>  
> diff --git a/drivers/platform/x86/lenovo/think-lmi.c b/drivers/platform/x86/lenovo/think-lmi.c
> index 34a47269e3d34d2eda6b71af73892656cd2bf67d..f61a6287eb0ebe9ac4c0c9445c3b54c12b276691 100644
> --- a/drivers/platform/x86/lenovo/think-lmi.c
> +++ b/drivers/platform/x86/lenovo/think-lmi.c
> @@ -20,7 +20,7 @@
>  #include <linux/types.h>
>  #include <linux/dmi.h>
>  #include <linux/wmi.h>
> -#include "../firmware_attributes_class.h"
> +#include <linux/firmware_attributes_class.h>
>  #include "think-lmi.h"
>  
>  static bool debug_support;
> diff --git a/drivers/platform/x86/samsung-galaxybook.c b/drivers/platform/x86/samsung-galaxybook.c
> index 5878a351993eb05a4c5c2c75b4915d972ce9becc..9a5a7b956a9f6a2738470e83ce93f4cccf4bf3b4 100644
> --- a/drivers/platform/x86/samsung-galaxybook.c
> +++ b/drivers/platform/x86/samsung-galaxybook.c
> @@ -28,7 +28,7 @@
>  #include <linux/uuid.h>
>  #include <linux/workqueue.h>
>  #include <acpi/battery.h>
> -#include "firmware_attributes_class.h"
> +#include <linux/firmware_attributes_class.h>
>  
>  #define DRIVER_NAME "samsung-galaxybook"
>  
> diff --git a/drivers/platform/x86/firmware_attributes_class.h b/include/linux/firmware_attributes_class.h
> similarity index 100%
> rename from drivers/platform/x86/firmware_attributes_class.h
> rename to include/linux/firmware_attributes_class.h


-- 
 ~ Kurt