linux-kernel - Re: [PATCH 2/2] filemap: Add __filemap_get_folio

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20250622151625.fb5d23362c2c3d1af22878d2@linux-foundation.org>
Date: Sun, 22 Jun 2025 15:16:25 -0700
From: Andrew Morton <akpm@...ux-foundation.org>
To: Shivank Garg <shivankg@....com>
Cc: Matthew Wilcox <willy@...radead.org>, seanjc@...gle.com,
 david@...hat.com, vbabka@...e.cz, shuah@...nel.org, pbonzini@...hat.com,
 brauner@...nel.org, viro@...iv.linux.org.uk, ackerleytng@...gle.com,
 paul@...l-moore.com, jmorris@...ei.org, serge@...lyn.com, pvorel@...e.cz,
 bfoster@...hat.com, tabba@...gle.com, vannapurve@...gle.com,
 chao.gao@...el.com, bharata@....com, nikunj@....com, michael.day@....com,
 yan.y.zhao@...el.com, Neeraj.Upadhyay@....com, thomas.lendacky@....com,
 michael.roth@....com, aik@....com, jgg@...dia.com, kalyazin@...zon.com,
 peterx@...hat.com, jack@...e.cz, rppt@...nel.org, hch@...radead.org,
 cgzones@...glemail.com, ira.weiny@...el.com, rientjes@...gle.com,
 roypat@...zon.co.uk, ziy@...dia.com, matthew.brost@...el.com,
 joshua.hahnjy@...il.com, rakie.kim@...com, byungchul@...com,
 gourry@...rry.net, kent.overstreet@...ux.dev, ying.huang@...ux.alibaba.com,
 apopple@...dia.com, chao.p.peng@...el.com, amit@...radead.org,
 ddutile@...hat.com, dan.j.williams@...el.com, ashish.kalra@....com,
 gshan@...hat.com, jgowans@...zon.com, pankaj.gupta@....com,
 papaluri@....com, yuzhao@...gle.com, suzuki.poulose@....com,
 quic_eberman@...cinc.com, aneeshkumar.kizhakeveetil@....com,
 linux-fsdevel@...r.kernel.org, linux-mm@...ck.org,
 linux-kernel@...r.kernel.org, linux-security-module@...r.kernel.org,
 kvm@...r.kernel.org, linux-kselftest@...r.kernel.org,
 linux-coco@...ts.linux.dev
Subject: Re: [PATCH 2/2] filemap: Add __filemap_get_folio_mpol()

On Mon, 23 Jun 2025 00:32:05 +0530 Shivank Garg <shivankg@....com> wrote:

> > -EXPORT_SYMBOL(__filemap_get_folio);
> > +EXPORT_SYMBOL(__filemap_get_folio_mpol);
> >  
> >  static inline struct folio *find_get_entry(struct xa_state *xas, pgoff_t max,
> >  		xa_mark_t mark)
> > _
> > 
> 
> Hi Andrew,
> 
> Thank you for addressing this.
> 
> If you don’t mind me asking,
> I was curious why we used EXPORT_SYMBOL instead of EXPORT_SYMBOL_GPL here.
> I had previously received feedback recommending the use of EXPORT_SYMBOL_GPL
> to better align with the kernel’s licensing philosophy, which made sense to me.

Making this _GPL would effectively switch __filemap_get_folio() from
non-GPL to GPL.  Leaving it at non-GPL is less disruptive and Matthew's
patch did not have the intention of changing licensing.

Also,

hp2:/usr/src/25> grep "EXPORT_SYMBOL(" mm/filemap.c|wc -l
48
hp2:/usr/src/25> grep "EXPORT_SYMBOL_GPL(" mm/filemap.c|wc -l 
9