lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <aFe62dzYPLktxZrH@archie.me>
Date: Sun, 22 Jun 2025 15:12:09 +0700
From: Bagas Sanjaya <bagasdotme@...il.com>
To: Abdelrahman Fekry <abdelrahmanfekry375@...il.com>, corbet@....net,
	davem@...emloft.net, edumazet@...gle.com, horms@...nel.org,
	kuba@...nel.org, pabeni@...hat.com
Cc: linux-doc@...r.kernel.org, linux-kernel-mentees@...ts.linux.dev,
	linux-kernel@...r.kernel.org, netdev@...r.kernel.org,
	skhan@...uxfoundation.com, jacob.e.keller@...el.com,
	alok.a.tiwari@...cle.com
Subject: Re: [PATCH net-next v4] docs: net: sysctl documentation cleanup

On Sun, Jun 22, 2025 at 09:27:24AM +0300, Abdelrahman Fekry wrote:
> @@ -1028,13 +1134,15 @@ tcp_shrink_window - BOOLEAN
>  	window can be offered, and that TCP implementations MUST ensure
>  	that they handle a shrinking window, as specified in RFC 1122.
>  
> -	- 0 - Disabled.	The window is never shrunk.
> -	- 1 - Enabled.	The window is shrunk when necessary to remain within
> +	Possible values:
> +
> +	- 0 (disabled)	The window is never shrunk.
> +	- 1 (enabled)	The window is shrunk when necessary to remain within
>  			the memory limit set by autotuning (sk_rcvbuf).
>  			This only occurs if a non-zero receive window
>  			scaling factor is also in effect.

The indentation for enabled option outputted like a definition list,
so I fix it up:

---- >8 ----
diff --git a/Documentation/networking/ip-sysctl.rst b/Documentation/networking/ip-sysctl.rst
index 682428b8f20507..e20cef49adf75c 100644
--- a/Documentation/networking/ip-sysctl.rst
+++ b/Documentation/networking/ip-sysctl.rst
@@ -1136,11 +1136,10 @@ tcp_shrink_window - BOOLEAN

 	Possible values:

-	- 0 (disabled)	The window is never shrunk.
-	- 1 (enabled)	The window is shrunk when necessary to remain within
-			the memory limit set by autotuning (sk_rcvbuf).
-			This only occurs if a non-zero receive window
-			scaling factor is also in effect.
+	- 0 (disabled) - The window is never shrunk.
+	- 1 (enabled) - The window is shrunk when necessary to remain within
+	  the memory limit set by autotuning (sk_rcvbuf). This only occurs if
+	  a non-zero receive window scaling factor is also in effect.

 	Default: 0 (disabled)

Thanks.

-- 
An old man doll... just what I always wanted! - Clara

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ