linux-kernel - Re: [PATCH 1/3] i3c: master: Add inline i3c_master_readsl and i3c_master

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ngtav2drgruaqyuwhhwdlsaex3c7fz5hbex47nzflabcwst2ln@6bmr73eqfzri>
Date: Sun, 22 Jun 2025 10:31:14 +0200
From: Jorge Marques <gastmaier@...il.com>
To: Wolfram Sang <wsa+renesas@...g-engineering.com>
Cc: Jorge Marques <jorge.marques@...log.com>, 
	Alexandre Belloni <alexandre.belloni@...tlin.com>, Frank Li <Frank.Li@....com>, 
	Przemysław Gaj <pgaj@...ence.com>, linux-i3c@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/3] i3c: master: Add inline i3c_master_readsl and
 i3c_master_writesl

On Fri, Jun 20, 2025 at 11:15:09PM +0200, Wolfram Sang wrote:
> On Fri, Jun 20, 2025 at 06:54:59PM +0200, Jorge Marques wrote:
> > The i3c abstraction excepts u8 buffers, but some controllers have a bus
> > width of 32-bits and don't support flagging valid bytes, so it is
> > required to read/write long words and to use memcpy on the remainder of
> > the number of bytes by 32-bits to not write/read outside the buffer
> > bounds.
> > 
> > Signed-off-by: Jorge Marques <jorge.marques@...log.com>
> 
> Suggested-by: Wolfram Sang <wsa+renesas@...g-engineering.com>
> 
> > + * i3c_master_writesl- Write bytes to long memory region from byte array
> 
Hi Wolfram,
> Frank proposed the name 'i3c_writel_fifo' which I like a tad better.
> Opinions?
>
I don't oppose the change and I'll rename, as well moving the method to
internals.h

  i3c_master_writesl -> i3c_writel_fifo
  i3c_master_readsl -> i3c_readl_fifo

Best Regards,
Jorge