linux-kernel - Re: [PATCH v15 3/9] ref_tracker: have callers pass output function to pr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <k3hx66pbtheyfs56jjbsdjotgukwk42vlrdbgbwhsajzx2sjbh@qrd4ms2ihm3n>
Date: Mon, 23 Jun 2025 12:57:58 +0000
From: Krzysztof Karas <krzysztof.karas@...el.com>
To: Jeff Layton <jlayton@...nel.org>
CC: Andrew Morton <akpm@...ux-foundation.org>, "David S. Miller"
	<davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski
	<kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, Simon Horman
	<horms@...nel.org>, Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>,
	Maxime Ripard <mripard@...nel.org>, Thomas Zimmermann <tzimmermann@...e.de>,
	David Airlie <airlied@...il.com>, Simona Vetter <simona@...ll.ch>, "Jani
 Nikula" <jani.nikula@...ux.intel.com>, Joonas Lahtinen
	<joonas.lahtinen@...ux.intel.com>, Rodrigo Vivi <rodrigo.vivi@...el.com>,
	Tvrtko Ursulin <tursulin@...ulin.net>, Kuniyuki Iwashima <kuniyu@...zon.com>,
	Qasim Ijaz <qasdev00@...il.com>, Nathan Chancellor <nathan@...nel.org>,
	Andrew Lunn <andrew@...n.ch>, <linux-kernel@...r.kernel.org>,
	<netdev@...r.kernel.org>, <dri-devel@...ts.freedesktop.org>,
	<intel-gfx@...ts.freedesktop.org>
Subject: Re: [PATCH v15 3/9] ref_tracker: have callers pass output function
 to pr_ostream()

Hi Jeff,

> In a later patch, we'll be adding a 3rd mechanism for outputting
> ref_tracker info via seq_file. Instead of a conditional, have the caller
> set a pointer to an output function in struct ostream. As part of this,
> the log prefix must be explicitly passed in, as it's too late for the
> pr_fmt macro.
> 
> Reviewed-by: Andrew Lunn <andrew@...n.ch>
> Signed-off-by: Jeff Layton <jlayton@...nel.org>
> ---
>  include/linux/ref_tracker.h |  2 ++
>  lib/ref_tracker.c           | 52 ++++++++++++++++++++++++++++++++-------------
>  2 files changed, 39 insertions(+), 15 deletions(-)
Looks good to me:
Reviewed-by: Krzysztof Karas <krzysztof.karas@...el.com>

Best Regards,
Krzysztof