linux-kernel - Re: [PATCH 5/5] KVM: arm64: gic-v5: Probe for GICv5

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f38fd2d51242f8b2e81da774426c5cec28e23fde.camel@arm.com>
Date: Mon, 23 Jun 2025 13:12:31 +0000
From: Sascha Bischoff <Sascha.Bischoff@....com>
To: "oliver.upton@...ux.dev" <oliver.upton@...ux.dev>
CC: "yuzenghui@...wei.com" <yuzenghui@...wei.com>, Timothy Hayes
	<Timothy.Hayes@....com>, Suzuki Poulose <Suzuki.Poulose@....com>, nd
	<nd@....com>, "lpieralisi@...nel.org" <lpieralisi@...nel.org>,
	"kvmarm@...ts.linux.dev" <kvmarm@...ts.linux.dev>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-arm-kernel@...ts.infradead.org"
	<linux-arm-kernel@...ts.infradead.org>, "kvm@...r.kernel.org"
	<kvm@...r.kernel.org>, Joey Gouly <Joey.Gouly@....com>, "maz@...nel.org"
	<maz@...nel.org>, "tglx@...utronix.de" <tglx@...utronix.de>,
	"will@...nel.org" <will@...nel.org>
Subject: Re: [PATCH 5/5] KVM: arm64: gic-v5: Probe for GICv5

On Fri, 2025-06-20 at 13:25 -0700, Oliver Upton wrote:
> On Fri, Jun 20, 2025 at 04:07:52PM +0000, Sascha Bischoff wrote:
> > +/**
> > + * vgic_v5_probe - probe for a VGICv5 compatible interrupt
> > controller
> > + * @info:	pointer to the GIC description
> > + *
> > + * Returns 0 if the VGICv5 has been probed successfully, returns
> > an error code
> > + * otherwise.
> > + */
> 
> nit: avoid kerneldoc style
> 
> This actually generates documentation as well as build warnings when
> we
> screw up the format. I'd only do this sort of thing for sufficiently
> public functions.
> 
> Thanks,
> Oliver

Done. Have made this into a non-kernel-doc comment.

FWIW, this was mimicking what is done for vgic_v3_probe.


Thanks,
Sascha
>