linux-kernel - Re: [PATCH 2/3] mm: update core kernel code to use vm_flags

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <9F6ABF80-EABC-45B1-ABEB-F3FA8D8B6B11@nvidia.com>
Date: Mon, 23 Jun 2025 10:33:40 -0400
From: Zi Yan <ziy@...dia.com>
To: Lorenzo Stoakes <lorenzo.stoakes@...cle.com>
Cc: Andrew Morton <akpm@...ux-foundation.org>,
 Russell King <linux@...linux.org.uk>,
 Catalin Marinas <catalin.marinas@....com>, Will Deacon <will@...nel.org>,
 Madhavan Srinivasan <maddy@...ux.ibm.com>,
 Michael Ellerman <mpe@...erman.id.au>, Nicholas Piggin <npiggin@...il.com>,
 Christophe Leroy <christophe.leroy@...roup.eu>,
 "David S . Miller" <davem@...emloft.net>,
 Andreas Larsson <andreas@...sler.com>, Jarkko Sakkinen <jarkko@...nel.org>,
 Dave Hansen <dave.hansen@...ux.intel.com>,
 Thomas Gleixner <tglx@...utronix.de>, Ingo Molnar <mingo@...hat.com>,
 Borislav Petkov <bp@...en8.de>, "H . Peter Anvin" <hpa@...or.com>,
 Andy Lutomirski <luto@...nel.org>, Peter Zijlstra <peterz@...radead.org>,
 Alexander Viro <viro@...iv.linux.org.uk>,
 Christian Brauner <brauner@...nel.org>, Jan Kara <jack@...e.cz>,
 Kees Cook <kees@...nel.org>, Peter Xu <peterx@...hat.com>,
 David Hildenbrand <david@...hat.com>,
 Baolin Wang <baolin.wang@...ux.alibaba.com>,
 "Liam R . Howlett" <Liam.Howlett@...cle.com>, Nico Pache <npache@...hat.com>,
 Ryan Roberts <ryan.roberts@....com>, Dev Jain <dev.jain@....com>,
 Barry Song <baohua@...nel.org>, Xu Xin <xu.xin16@....com.cn>,
 Chengming Zhou <chengming.zhou@...ux.dev>, Hugh Dickins <hughd@...gle.com>,
 Vlastimil Babka <vbabka@...e.cz>, Mike Rapoport <rppt@...nel.org>,
 Suren Baghdasaryan <surenb@...gle.com>, Michal Hocko <mhocko@...e.com>,
 Rik van Riel <riel@...riel.com>, Harry Yoo <harry.yoo@...cle.com>,
 Dan Williams <dan.j.williams@...el.com>,
 Matthew Wilcox <willy@...radead.org>, Steven Rostedt <rostedt@...dmis.org>,
 Masami Hiramatsu <mhiramat@...nel.org>,
 Mathieu Desnoyers <mathieu.desnoyers@...icios.com>,
 Jason Gunthorpe <jgg@...pe.ca>, John Hubbard <jhubbard@...dia.com>,
 Muchun Song <muchun.song@...ux.dev>, Oscar Salvador <osalvador@...e.de>,
 Jann Horn <jannh@...gle.com>, Pedro Falcato <pfalcato@...e.de>,
 Johannes Weiner <hannes@...xchg.org>, Qi Zheng <zhengqi.arch@...edance.com>,
 Shakeel Butt <shakeel.butt@...ux.dev>, linux-arm-kernel@...ts.infradead.org,
 linux-kernel@...r.kernel.org, linuxppc-dev@...ts.ozlabs.org,
 kvm@...r.kernel.org, sparclinux@...r.kernel.org, linux-sgx@...r.kernel.org,
 linux-fsdevel@...r.kernel.org, linux-mm@...ck.org, nvdimm@...ts.linux.dev,
 linux-trace-kernel@...r.kernel.org
Subject: Re: [PATCH 2/3] mm: update core kernel code to use vm_flags_t
 consistently

On 18 Jun 2025, at 15:42, Lorenzo Stoakes wrote:

> The core kernel code is currently very inconsistent in its use of
> vm_flags_t vs. unsigned long. This prevents us from changing the type of
> vm_flags_t in the future and is simply not correct, so correct this.
>
> While this results in rather a lot of churn, it is a critical pre-requisite
> for a future planned change to VMA flag type.
>
> Additionally, update VMA userland tests to account for the changes.
>
> To make review easier and to break things into smaller parts, driver and
> architecture-specific changes is left for a subsequent commit.
>
> The code has been adjusted to cascade the changes across all calling code
> as far as is needed.
>
> We will adjust architecture-specific and driver code in a subsequent patch.
>
> Overall, this patch does not introduce any functional change.
>
> Signed-off-by: Lorenzo Stoakes <lorenzo.stoakes@...cle.com>
> ---
>  fs/exec.c                        |   2 +-
>  fs/userfaultfd.c                 |   2 +-
>  include/linux/coredump.h         |   2 +-
>  include/linux/huge_mm.h          |  12 +-
>  include/linux/khugepaged.h       |   4 +-
>  include/linux/ksm.h              |   4 +-
>  include/linux/memfd.h            |   4 +-
>  include/linux/mm.h               |   6 +-
>  include/linux/mm_types.h         |   2 +-
>  include/linux/mman.h             |   4 +-
>  include/linux/rmap.h             |   4 +-
>  include/linux/userfaultfd_k.h    |   4 +-
>  include/trace/events/fs_dax.h    |   6 +-
>  mm/debug.c                       |   2 +-
>  mm/execmem.c                     |   8 +-
>  mm/filemap.c                     |   2 +-
>  mm/gup.c                         |   2 +-
>  mm/huge_memory.c                 |   2 +-
>  mm/hugetlb.c                     |   4 +-
>  mm/internal.h                    |   4 +-
>  mm/khugepaged.c                  |   4 +-
>  mm/ksm.c                         |   2 +-
>  mm/madvise.c                     |   4 +-
>  mm/mapping_dirty_helpers.c       |   2 +-
>  mm/memfd.c                       |   8 +-
>  mm/memory.c                      |   4 +-
>  mm/mmap.c                        |  16 +-
>  mm/mprotect.c                    |   8 +-
>  mm/mremap.c                      |   2 +-
>  mm/nommu.c                       |  12 +-
>  mm/rmap.c                        |   4 +-
>  mm/shmem.c                       |   6 +-
>  mm/userfaultfd.c                 |  14 +-
>  mm/vma.c                         |  78 ++++-----
>  mm/vma.h                         |  16 +-
>  mm/vmscan.c                      |   4 +-
>  tools/testing/vma/vma.c          | 266 +++++++++++++++----------------
>  tools/testing/vma/vma_internal.h |   8 +-
>  38 files changed, 269 insertions(+), 269 deletions(-)
>

Acked-by: Zi Yan <ziy@...dia.com>


--
Best Regards,
Yan, Zi