linux-kernel - Re: [PATCH] staging: rtl8723bs: replace msleep(1)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <a775180c-3ecc-4fb9-bd8f-9f8bacba94f9@suswa.mountain>
Date: Mon, 23 Jun 2025 18:16:25 +0300
From: Dan Carpenter <dan.carpenter@...aro.org>
To: Kisub Choe <kisub.choe.0x1@...il.com>
Cc: gregkh@...uxfoundation.org, philipp.g.hortmann@...il.com,
	linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: rtl8723bs: replace msleep(1)

On Mon, Jun 23, 2025 at 11:35:27PM +0900, Kisub Choe wrote:
> On Mon, Jun 23, 2025 at 01:54:01PM +0300, Dan Carpenter wrote:
> > On Sun, Jun 22, 2025 at 08:28:16AM +0900, Kisub Choe wrote:
> > > changed msleep to usleep_range to
> > > 
> > > Adhere to Linux kernel coding style.
> > > Reported by checkpatch:
> > > 
> > > WARNING: msleep < 20ms can sleep for up to 20ms;
> > > see function description of msleep().
> > > 
> > > Signed-off-by: Kisub Choe <kisub.choe.0x1@...il.com>
> > 
> > This type of change needs to be tested before it can be merged.
> > 
> > regards,
> > dan carpenter
> > 
> 
> Thank you for feedback.
> I understand that this type of change should be tested due to its impact
> on time-sensitive behavior.
> However, I currently don't have access to any device that uses this
> driver.
> Please let me know how you'd suggest proceeding in this case.

Just leave it as-is until someone who has the hardware can test it.

regards,
dan carpenter